Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #8: fix duplicate urls #13

Merged
merged 2 commits into from
Apr 29, 2024
Merged

issue #8: fix duplicate urls #13

merged 2 commits into from
Apr 29, 2024

Conversation

k-allagbe
Copy link
Member

@k-allagbe k-allagbe commented Apr 29, 2024 •
edited
Loading

  • investigation
  • fixed an issue where node_ids referenced documents instead of chunks
  • fixed duplicate ulrs
  • added test and all tests pass
  • updated docs

@k-allagbe k-allagbe requested a review from a team as a code owner April 29, 2024 00:23
@k-allagbe k-allagbe linked an issue Apr 29, 2024 that may be closed by this pull request
Duplicated URL Results in llamaindex-db #12
Open
5 tasks
@k-allagbe k-allagbe self-assigned this Apr 29, 2024
@k-allagbe k-allagbe marked this pull request as draft April 29, 2024 00:23
@k-allagbe k-allagbe force-pushed the 12-duplicated-url-results-with-ai-lab-llamaindex-search-in-llamaindex-db branch from 8e24724 to 10c9993 Compare April 29, 2024 00:26
@k-allagbe k-allagbe force-pushed the 12-duplicated-url-results-with-ai-lab-llamaindex-search-in-llamaindex-db branch from 10c9993 to 03fc62a Compare April 29, 2024 00:38
@k-allagbe k-allagbe marked this pull request as ready for review April 29, 2024 00:46
k-allagbe added a commit to ai-cfia/finesse-backend that referenced this pull request Apr 29, 2024
@k-allagbe
issue #57: update to support ai-cfia/llamaindex-db#13
aaf81fe
@k-allagbe k-allagbe mentioned this pull request Apr 29, 2024
Merged
7 tasks
@k-allagbe k-allagbe merged commit e1a3c84 into main Apr 29, 2024
6 checks passed
k-allagbe added a commit to ai-cfia/finesse-backend that referenced this pull request Apr 30, 2024
@k-allagbe
Merge pull request #58 from ai-cfia/57-fix-llamaindex-duplicates
a406cee 
issue #57: update to support ai-cfia/llamaindex-db#13
@k-allagbe k-allagbe mentioned this pull request May 2, 2024
Closed
5 tasks
@k-allagbe
Copy link
Member Author

image

"Est-ce qu'un produit peut avoir 2 pays d'origine sur son étiquette?"

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPelletierEvraire SamuelPelletierEvraire SamuelPelletierEvraire approved these changes

@leejaeka leejaeka Awaiting requested review from leejaeka

@amirardalan9473 amirardalan9473 Awaiting requested review from amirardalan9473

@ThomasCardin ThomasCardin Awaiting requested review from ThomasCardin

@SonOfLope SonOfLope Awaiting requested review from SonOfLope

@ChromaticPanic ChromaticPanic Awaiting requested review from ChromaticPanic

Assignees

@k-allagbe k-allagbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated URL Results in llamaindex-db
2 participants
@k-allagbe @SamuelPelletierEvraire