Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3: Adds initial setup for aks cluster on Azure #40

Merged

Conversation

SonOfLope
Copy link
Contributor

@SonOfLope SonOfLope commented Feb 12, 2024

This PR is allowing an aks cluster to be created with admin access given to defined ad_groups variable.
It aims to achieve the following :

  • : Provide a reusable module for kubernetes allowing deployment in different regions.
  • : Provide a reusable virtual network allowing separation of concerns and reusability.
  • : Creates a staging aks cluster for the team.

@SonOfLope SonOfLope marked this pull request as ready for review February 13, 2024 17:08
@rngadam rngadam requested a review from cfiaGeetika February 13, 2024 19:07
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that I could get started deploying my own kubernetes cluster from the README.md. How could we get this to the point where anyone can create a kubernetes cluster on Azure free credits? Also getting queueing someone from Microsoft to review. Can be done in a future issue.

@rngadam
Copy link

rngadam commented Feb 13, 2024

@SonOfLope ...also the description checklist has no checkmarks.

looks very clean, nice naming.

@SonOfLope
Copy link
Contributor Author

@SonOfLope ...also the description checklist has no checkmarks.

looks very clean, nice naming.

Thank you! Added the checkmarks.

@SonOfLope
Copy link
Contributor Author

SonOfLope commented Feb 13, 2024

I'm not entirely sure that I could get started deploying my own kubernetes cluster from the README.md. How could we get this to the point where anyone can create a kubernetes cluster on Azure free credits? Also getting queueing someone from Microsoft to review. Can be done in a future issue.

I added some information in README.md. Currently since we use Devops Azure for the pipeline it would not be an ideal set up for someone to try it so I will open an issue for it and hopefully by then we are no longer using Azure Devops.

Issue created : #41

@SonOfLope SonOfLope merged commit 79b6cbd into main Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants