Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #25: DSS to explain the topologie of this infrastructure #35

Conversation

@ThomasCardin ThomasCardin changed the title Issue #25: ingress diagram Issue #25: DSS to explain the topologie of this infrastructure Feb 7, 2024
@ThomasCardin
Copy link
Member Author

Waiting on this PR to be merged before merging this one

@ThomasCardin ThomasCardin marked this pull request as ready for review February 7, 2024 21:40
@ThomasCardin
Copy link
Member Author

ThomasCardin commented Feb 7, 2024

The first diagram of the global_overview.md isn't rendering. An issue is currently open on the mermaid repo. Also, their's no linter for mermaid. See mermaid-js/mermaid#4450

@SonOfLope
Copy link
Contributor

The first diagram of the global_overview.md isn't rendering. An issue is currently open on the mermaid repo. Also, their's no linter for mermaid. See mermaid-js/mermaid#4450

I can confirm it works locally on my machine so it is an issue with github rendering.

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be helpful for explaining infrastructure and architecture to developers and stakeholders so good job!

I would integrate the work from @MaxenceGui and @ibrahim-kabir on explaining an architecture where models are pushed to be part of the database layers instead of the business layer.

Copy link
Contributor

@SonOfLope SonOfLope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! For the first diagram are we just keeping it with mermaid even tho it doesnt render ?

@ThomasCardin
Copy link
Member Author

LGTM! For the first diagram are we just keeping it with mermaid even tho it doesnt render ?

I think we should keep it. Next time we have to update the documentation. If the diagram didn't resolved itself, I guess we just remove it. Waiting on this issue to be resolved mermaid-js/mermaid#4450

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there changes not pushed?

@ThomasCardin
Copy link
Member Author

ThomasCardin commented Feb 13, 2024

Forgot the ingress.md my bad

@rngadam
Copy link

rngadam commented Feb 13, 2024

Forgot the ingress.md my bad

linter failing, I think because these files are linked from the README.md

@ThomasCardin ThomasCardin merged commit 440bdb4 into main Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

As a DevOps, I want to create a DSS and multiple diagram to show and preview our infrastructure
3 participants