-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #25: DSS to explain the topologie of this infrastructure #35
Issue #25: DSS to explain the topologie of this infrastructure #35
Conversation
ThomasCardin
commented
Feb 7, 2024
- Closes As a DevOps, I want to create a DSS and multiple diagram to show and preview our infrastructure #25
Waiting on this PR to be merged before merging this one |
The first diagram of the global_overview.md isn't rendering. An issue is currently open on the mermaid repo. Also, their's no linter for mermaid. See mermaid-js/mermaid#4450 |
I can confirm it works locally on my machine so it is an issue with github rendering. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be helpful for explaining infrastructure and architecture to developers and stakeholders so good job!
I would integrate the work from @MaxenceGui and @ibrahim-kabir on explaining an architecture where models are pushed to be part of the database layers instead of the business layer.
…ew to generic architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! For the first diagram are we just keeping it with mermaid even tho it doesnt render ?
I think we should keep it. Next time we have to update the documentation. If the diagram didn't resolved itself, I guess we just remove it. Waiting on this issue to be resolved mermaid-js/mermaid#4450 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there changes not pushed?
Forgot the |
linter failing, I think because these files are linked from the README.md |