Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /brotli endpoint #27

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Add /brotli endpoint #27

merged 1 commit into from
Sep 21, 2020

Conversation

gaul
Copy link
Contributor

@gaul gaul commented Sep 21, 2020

Parity with http://httpbin.org/ . This is similar to #20 but uses a
Go-only implementation translated by c2go:

https://github.com/andybalholm/brotli

@gaul
Add /brotli endpoint
38b0021 
Parity with http://httpbin.org/ .  This is similar to ahmetb#20 but uses a
Go-only implementation translated by c2go:

https://github.com/andybalholm/brotli
ahmetb
ahmetb approved these changes Sep 21, 2020
View reviewed changes
Copy link
Owner

@ahmetb ahmetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces a new dependency . 🤔 Would be cool to somehow maybe have a .../brotli sub-package and side-effect-import it e.g. import _ [...]/brotli to actually activate this endpoint, but I guess it’s not that big of a deal.

@ahmetb ahmetb merged commit 862fbad into ahmetb:master Sep 21, 2020
@gaul gaul deleted the brotli branch September 22, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmetb ahmetb ahmetb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaul @ahmetb