Optimize memory performance #47
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
force-pushed
the
mhofman/optimize-memory
branch
from
0ff3460 to
79c32f8
Compare
|
back to draft as we haven't seen this having a positive impact in perf testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up the commit form #44 which causes xsnap memory to be allocated contiguously. Moddable believes this change can alleviate some of the performance impact described in Agoric/agoric-sdk#6661. We have not yet measure the impact, but I plan to do so in the next validation replay run. While we currently have a workaround to restart from snapshot in agoric-sdk, and we're likely to keep that enabled in production to reduce the risk of divergence between validators, we do want the option to execute deliveries in a worker without restarting at every snapshot taken.