refactor

agiledragon · Jul 28, 2019 · 7656bf8 · 7656bf8
1 parent 9b8044a
commit 7656bf8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/domain/model/remote-account/RemoteMoneyDest.cpp b/src/domain/model/remote-account/RemoteMoneyDest.cpp
@@ -5,8 +5,8 @@
 void RemoteMoneyDest::transferMoneyFrom(const std::string& fromId, U32 amount)
 {
 	sendTransferToProtocolMsg(fromId, ROLE(AccountInfo).getAccountId(), amount);
-	Response resp = waitProtocolResp();
-	if (resp.isFailed)
+	Response ok = waitProtocolResp();
+	if (ok.isFailed)
 	{
 		throw "transfer money to remote fail!";
 	}

diff --git a/test/TestAccount.cpp b/test/TestAccount.cpp
@@ -93,33 +93,30 @@ struct TestAccount : testing::Test
 	FakeAccountRepo* accountRepo;
 	const U32 JIM_INIT_AMOUNT{10000};
 	const U32 LUCY_INIT_AMOUNT{5000};
+	const U32 AMOUNT{1500};
 };
 
 TEST_F(TestAccount, withdraw_money)
 {
-	const U32 AMOUNT = 1500;
 	api->withdrawMoney(jimAccountId, AMOUNT);
 	ASSERT_EQ(JIM_INIT_AMOUNT - AMOUNT, api->getAmount(jimAccountId));
 }
 
 TEST_F(TestAccount, transfer_money_to_local)
 {
-	const U32 AMOUNT = 1500;
 	api->transferMoneyToLocal(jimAccountId, lucyAccountId, AMOUNT);
 	ASSERT_EQ(JIM_INIT_AMOUNT - AMOUNT, api->getAmount(jimAccountId));
 	ASSERT_EQ(LUCY_INIT_AMOUNT + AMOUNT, api->getAmount(lucyAccountId));
 }
 
 TEST_F(TestAccount, transfer_money_to_remote)
 {
-	const U32 AMOUNT = 1500;
 	api->transferMoneyToRemote(jimAccountId, lucyAccountId, AMOUNT);
 	ASSERT_EQ(JIM_INIT_AMOUNT - AMOUNT, api->getAmount(jimAccountId));
 }
 
 TEST_F(TestAccount, transfer_money_from_remote)
 {
-	const U32 AMOUNT = 1500;
 	api->transferMoneyFromRemote(lucyAccountId, jimAccountId, AMOUNT);
 	ASSERT_EQ(JIM_INIT_AMOUNT + AMOUNT, api->getAmount(jimAccountId));
 }