Feature improved gm performance #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were bugs preventing the window from refreshing properly. Those have been corrected. While the window was closed, it was also refreshing in the background and making other windows/widget slow. So, the refreshing feature only happens now when the window is open. The timer behind it will start/stop with respect to the window being opened or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Game Manager Window was causing performance slow downs. It's designed to be basic on purpose so it uses a timer to refresh the GUI/Widget. That refresh would happen whether or not the window was open, so some improvements were made so that the refresh logic doesn't run while the window is closed. Making this change revealed some other bugs, so those were corrected at the same time.