Biconomy comment fixes

autotx/intents.py

@@ -28,7 +28,7 @@ class IntentBase(BaseModel):
 
     @abstractmethod
     async def build_transactions(self, web3: Web3, network: NetworkInfo, smart_wallet_address: ETHAddress) -> list[Transaction]:
-        pass
+        raise NotImplementedError()
 
 class SendIntent(IntentBase):
     receiver: str

autotx/load_tokens.py

@@ -1,3 +1,4 @@
+import asyncio
 import json
 from textwrap import dedent
 from typing import Union
@@ -42,5 +43,5 @@ async def fetch_tokens_list() -> None:
         f.write(content)
 
 
-async def run() -> None:
-    await fetch_tokens_list()
+def run() -> None:
+    asyncio.run(fetch_tokens_list())

autotx/smart_accounts/smart_account.py

@@ -21,15 +21,15 @@ def on_intents_prepared(self, intents: list[Intent]) -> None:
 
     @abstractmethod
     async def on_intents_ready(self, intents: list[Intent]) -> bool | str: # True if sent, False if declined, str if feedback
-        pass
+        raise NotImplementedError()
 
     @abstractmethod
     async def send_transaction(self, transaction: TransactionBase) -> None:
-       pass
+        raise NotImplementedError()
 
     @abstractmethod
     async def send_transactions(self, transactions: list[TransactionBase]) -> None:
-        pass
+        raise NotImplementedError()
 
     def wait(self, tx_hash: HexBytes) -> TxReceipt:
         return self.web3.eth.wait_for_transaction_receipt(tx_hash)

smart_account_api/src/index.ts

@@ -40,6 +40,10 @@ app.use((req: Request, res: Response, next: NextFunction) => {
 
 app.get("/api/v1/account/address", handleError(async (req: Request, res: Response) => {
   const chainId = parseInt(req.query.chainId as string);
+  if (!chainId) {
+    res.status(400).json({ error: "chainId is required" });
+    return;
+  }
 
   const { smartAccount } = await initClientWithAccount(SMART_ACCOUNT_OWNER_PK, chainId);
 
@@ -52,6 +56,10 @@ app.get("/api/v1/account/address", handleError(async (req: Request, res: Respons
 
 app.post("/api/v1/account/deploy", handleError(async (req: Request, res: Response) => {
   const chainId = parseInt(req.query.chainId as string);
+  if (!chainId) {
+    res.status(400).json({ error: "chainId is required" });
+    return;
+  }
 
   const { smartAccount } = await initClientWithAccount(SMART_ACCOUNT_OWNER_PK, chainId);
 
@@ -64,6 +72,10 @@ app.post("/api/v1/account/deploy", handleError(async (req: Request, res: Respons
 
 app.post("/api/v1/account/transactions", handleError(async (req: Request, res: Response, next: NextFunction) => {
   const chainId = parseInt(req.query.chainId as string);
+  if (!chainId) {
+    res.status(400).json({ error: "chainId is required" });
+    return;
+  }
 
   const transactions: TransactionDto[] = req.body;