Add Benchmark 7 of Aubry et al. (2022) as a Scenario2 variant #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
NDK's simulation scenarios are based on Jean-Francois Aubry, et al. (2022). Specifically, Scenario 1 corresponds to Benchmark 4 in the paper, and Scenario 2 corresponds to Benchmark 8 in the paper.
NDK's 3-D simulations run much faster on a GPU, but at standard resolutions, Scenario 2 (i.e., benchmark 8) is too large to fit on a single GPU's memory. Aubry, et al. (2022) also mention a related Benchmark 7, which is the same set up as benchmark 8 but simulated over a sub-volume of the skull/brain. Benchmark 7 uses the same volume size as Benchmark 4 and thus fits in a GPU.
Benchmark 7 would thus be useful as an easier-to-run alternative to Benchmark 8.
Changes
Scenario2_2D_Benchmark7
as a subclass ofScenario2_2D
Scenario2_3D_Benchmark7
as a subclass ofScenario2_3D
Design decisions:
Scenario2
extent
variable to subslice the existingScenario
. Con: resulting code was less straightforwardScenario
class. Con: more places to update/maintain code if refactoring in the futureTesting
Can initialize
Scenario2_3D_Benchmark7
in your codeCan adapt


plot_scenarios.py
(did not check in this change) to includeScenario2_3D_Benchmark7
and see results:New scenarios added to
test_builtin.py