Skip to content

Commit

Permalink
Fix enableReproducibleCompare setting (#724)
Browse files Browse the repository at this point in the history
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
  • Loading branch information
sophia-guo authored Jun 13, 2023
1 parent 198bfce commit 04dda51
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion pipelines/build/common/build_base_file.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,9 @@ class Builder implements Serializable {
if (configuration.containsKey('reproducibleCompare')) {
def reproducibleCompare
if (isMap(configuration.reproducibleCompare)) {
reproducibleCompare = (configuration.enableReproducibleCompare as Map).get(variant)
reproducibleCompare = (configuration.reproducibleCompare as Map).get(variant)
} else {
reproducibleCompare = configuration.reproducibleCompare
}
if (reproducibleCompare != null) {
enableReproducibleCompare = reproducibleCompare
Expand Down
6 changes: 4 additions & 2 deletions pipelines/build/common/config_regeneration.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -337,14 +337,16 @@ class Regeneration implements Serializable {
/*
* Get reproduciableCompare flag from jdk*_pipeline_config.groovy. Used when creating the IndividualBuildConfig.
* @param configuration
* @param variant
* @param variant
*/
Boolean getReproducibleCompare(Map<String, ?> configuration, String variant) {
Boolean enableReproducibleCompare = DEFAULTS_JSON['testDetails']['enableReproducibleCompare'] as Boolean
if (configuration.containsKey('reproducibleCompare')) {
def reproducibleCompare
if (isMap(configuration.reproducibleCompare)) {
reproducibleCompare = (configuration.enableReproducibleCompare as Map).get(variant)
reproducibleCompare = (configuration.reproducibleCompare as Map).get(variant)
} else {
reproducibleCompare = configuration.reproducibleCompare
}
if (reproducibleCompare != null) {
enableReproducibleCompare = reproducibleCompare
Expand Down

0 comments on commit 04dda51

Please sign in to comment.