Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for running custom serviceability jvmti test #5357

Closed
fengxue-IS opened this issue May 29, 2024 · 9 comments
Closed

Add support for running custom serviceability jvmti test #5357

fengxue-IS opened this issue May 29, 2024 · 9 comments

Comments

@fengxue-IS
Copy link
Contributor

I'd like to request ability to run custom serviceability jvmti test.
Ideally with new test target:
serviceability_jvmti_custom
where a custom test path can be provided.

default test to run:
serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

@fengxue-IS
Copy link
Contributor Author

FYI @llxia

@llxia
Copy link
Contributor

llxia commented May 30, 2024

On second thought, instead of creating a separate test target for serviceability, maybe we can leverage the existing hotspot_custom

<testCaseName>hotspot_custom</testCaseName>

Remove

<impls>
<impl>hotspot</impl>
</impls>
and disable <impl>openj9</impl> via <disables>.

In this way, openj9 dev users can run any hotspot folder target via TARGET=disabled.hotspot_custom.

@LongyuZhang could you take care of this one? Thanks

@LongyuZhang
Copy link
Contributor

Tested running with TARGET: disabled.hotspot_custom, and CUSTOM_TARGET: serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java.
The test runs but the CUSTOM_TARGET was not taken as hotspot_custom runs HOTSPOT_CUSTOM_TARGET (link) instead.
Found a related open issue #4408, which needs to be resolved first.

@llxia
Copy link
Contributor

llxia commented Jun 7, 2024

just for the record, usage for openj9

TARGET=disabled.hotspot_custom
CUSTOM_TARGET=serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

@LongyuZhang
Copy link
Contributor

Close this issue as fixed by #5370.

@sophia-guo
Copy link
Contributor

sophia-guo commented Jun 28, 2024

Note per #5370, for openj9, hotspot_custom can only be used for serviceability jvmti test jdk19+ with the -nativepath set as hotspot native path -nativepath:"$(TESTIMAGE_PATH)/hotspot/jtreg/native, which meets currently requirements. It won't work if tests require openj9 nativepath. Better to add some comments or update some documents.

@sophia-guo
Copy link
Contributor

sophia-guo commented Jun 28, 2024

I would prefer to add a custom serviceability jvmti test target instead of using hotspot_custom as a hack, which is confusing.

@sophia-guo
Copy link
Contributor

#5491

@LongyuZhang
Copy link
Contributor

LongyuZhang commented Aug 14, 2024

Updated the usage for openj9 via #5493:

TARGET=hotspot_custom_j9
CUSTOM_TARGET=serviceability/jvmti/GetSystemProperty/JvmtiGetSystemPropertyTest.java

FYI @fengxue-IS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants