Skip to content

Commit

Permalink
Make things work on Windows
Browse files Browse the repository at this point in the history
Problem: Theano relies on g++, which means we need to install MinGW on
         Windows.  Unfortunately, MinGW is incompatible with MSVC 2015,
         which is used to build libpython3.5 (necessary for linking).
         See ContinuumIO/anaconda-issues#561
Solution: Downgrade to Python 3.4

Problem: Currently, `environment.yml` doesn't support platform-specific
         selectors. We're waiting on conda env to merge
         conda-archive/conda-env#213
Solution: Run `conda install libpython` as a seperate step on Windows
          only
  • Loading branch information
alanhdu committed Feb 15, 2016
1 parent 4eaa2cb commit 9f15ce3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ build_script:
- conda update --yes --quiet conda
- conda env create --quiet --name accessibleml
- activate accessibleml
- conda install --yes --quiet libpython
before_test:
- conda env export
test_script:
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ dependencies:
- pandas=0.17
- pillow=3.1
- pytest # testing dependency
- python=3.5
- python=3.4
- scikit-learn=0.17
- scipy=0.17
- statsmodels=0.6
Expand Down
4 changes: 2 additions & 2 deletions test/test_notebook.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
import nbformat
import pytest

notebooks = list(glob.glob("*.ipynb", recursive=True))
notebooks = sorted(glob.glob("*.ipynb"))


@pytest.mark.parametrize("notebook", notebooks)
def test_notebook_execution(notebook):
with open(notebook) as fin:
nb = nbformat.read(fin, as_version=4)

ep = ExecutePreprocessor(timeout=1200, kernel_name="python3")
ep = ExecutePreprocessor(timeout=2400, kernel_name="python3")
ep.preprocess(nb, resources={})


Expand Down

0 comments on commit 9f15ce3

Please sign in to comment.