Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the way healtcheck is added #10

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tjamet
Copy link
Contributor

@tjamet tjamet commented Nov 29, 2024

Goal

Ease tests and increase code readability

Committer details Local-Branch: HEAD
Related changes
Future changes
refactor ingress backend pod detection (#11) Move the detection at the ingress level rather than per rule

Goals

  • Prepare the case to support multiple ingress controllers through CRDs
  • Increase code readability and testeability
Prevent changing dnsEndpoint name and namespace attributes in createOrUpdate (#12) This is not permitted by controllerRuntime and should not be performed
Refactor DNS name extraction (#13) Goal ---

Ease the implementation of CRD based multi-ingress controller traffic routing

Add fine-grain ingress DNS control through CRD (#14) Context ---

Handling usual cluster operations, we often come to operate higher risk changes like bumping ingress controller
versions, changing the underneath ingress service type (for example moving from an AWS ELB to an AWS NLB).

Doing so, the safest way would be to be able to provision a new ingress controller and progressively migrating traffic
to the new instance.

Problems

Currently, traffic controller reads the host and load balancer reference using
the ingress status.

This prevents from being able to handle and control weighted records across the different ingress controllers.

Goal

Enable fine-grained routing between various ingress controllers in the same cluster.

Unblocked use-cases

  • Progressively change and test the ingress infrastructure (load balancer, ...) and versions
  • Allow sharding ingress controllers at the DNS level

@tjamet tjamet force-pushed the maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3 branch from ec84cff to d13fb31 Compare December 10, 2024 10:54
@tjamet tjamet force-pushed the maiao.Iadd6a6ec887c6b70f7d931a4f0983f6e9b7d8d52 branch from f820a6c to 1eac580 Compare December 10, 2024 10:54
@tjamet tjamet force-pushed the maiao.Iadd6a6ec887c6b70f7d931a4f0983f6e9b7d8d52 branch from 1eac580 to 5ba04ab Compare December 10, 2024 11:17
@tjamet tjamet force-pushed the maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3 branch from d13fb31 to 10007ac Compare December 10, 2024 11:17
Goal
---

Ease tests and increase code readability

Change-Id: I12dc66552733eaa5e6258df00a659d6bf410f9c3
@tjamet tjamet force-pushed the maiao.I12dc66552733eaa5e6258df00a659d6bf410f9c3 branch from 10007ac to 306e626 Compare December 10, 2024 11:43
@tjamet tjamet changed the title [need #9] refactor the way healtcheck is added refactor the way healtcheck is added Dec 10, 2024
@tjamet tjamet changed the base branch from maiao.Iadd6a6ec887c6b70f7d931a4f0983f6e9b7d8d52 to main December 10, 2024 11:43
@tjamet tjamet merged commit d2a3d4b into main Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants