Skip to content

Commit

Permalink
Prevent changing dnsEndpoint name and namespace attributes in createO…
Browse files Browse the repository at this point in the history
…rUpdate

This is not permitted by controllerRuntime and should not be performed

Change-Id: I5f01e93edd2b8c48689588a871905047d4fbed8f
  • Loading branch information
Thibault Jamet committed Nov 29, 2024
1 parent 120e1fc commit 832eea3
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions pkg/controllers/ingress_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,6 @@ func (r *IngressReconciler) newDnsEndpoint(ctx context.Context, dnsEndpoint *ext

setOwnerRef(dnsEndpoint, &ingress)

dnsEndpoint.Name = ingress.ObjectMeta.Name
dnsEndpoint.Namespace = ingress.ObjectMeta.Namespace
desiredWeight = uint(trafficweight.Store.DesiredWeight)
if r.isIngressWeighted(ingress) {
desiredWeight, err = r.calculateIngressWeight(ingress)
Expand Down

0 comments on commit 832eea3

Please sign in to comment.