Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE on CalloutContract #5

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Fix NPE on CalloutContract #5

merged 1 commit into from
Nov 2, 2024

Conversation

carlosaparadam
Copy link
Contributor

Summary

At create new contract, trigger an null pointer exception when do not selected an Price List or don't have an valid price list version for the contract.

Steps for review:

  • Go to option /Service Management/Contract Lifecycle Management/Contract
  • Create new Record

image

Screenshot_20240223_103658

Error

-----------> CConnection.isAppsServerOK: :3700
 - javax.naming.NoInitialContextException: Need to specify class name in environment or system property, or in an application resource file: java.naming.factory.initial
 - {} [1]
javax.naming.NoInitialContextException: Need to specify class name in environment or system property, or in an application resource file: java.naming.factory.initial
	at java.naming/javax.naming.spi.NamingManager.getInitialContext(NamingManager.java:702)
	at java.naming/javax.naming.InitialContext.getDefaultInitCtx(InitialContext.java:305)
	at java.naming/javax.naming.InitialContext.getURLOrDefaultInitCtx(InitialContext.java:342)
	at java.naming/javax.naming.InitialContext.lookup(InitialContext.java:409)
	at org.compiere.db.CConnection.lookup(CConnection.java:1787)
	at org.compiere.db.CConnection.isAppsServerOK(CConnection.java:398)
	at org.compiere.db.CConnectionEditor.setDisplay(CConnectionEditor.java:214)
	at org.compiere.db.CConnectionEditor.setValue(CConnectionEditor.java:182)
	at org.compiere.apps.ALogin.initLogin(ALogin.java:361)
	at org.compiere.apps.AMenu.initSystem(AMenu.java:245)
	at org.compiere.apps.AMenu.<init>(AMenu.java:113)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:490)
	at java.base/java.lang.Class.newInstance(Class.java:584)
	at org.adempiere.Adempiere.main(Adempiere.java:651)
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.erpya.lve.model.LVE [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.erpya.lve.model.LVE [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.conversion.model.validator.CurrencyConvertDocuments [20]
-----------> ModelValidationEngine.loadValidatorClass: client ANROS already exists for class: org.spin.conversion.model.validator.CurrencyConvertDocuments [20]
-----------> ModelValidationEngine.loadValidatorClass: client ANROS already exists for class: org.spin.wms.model.validator.ProductValidation [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.model.validator.TravelAgencyManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.cash.model.validator.CashManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.consignment.model.validator.ConsignedMaterial [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.tpa.model.validator.ThirdPartyAccess [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.eos.model.validator.ConversionRate [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.eos.model.validator.ExchangeOperations [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.model.validator.FiscalPrinter [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.model.Withholding [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.erpya.lve.model.FinancialBigTransactionTax [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.erpya.lve.model.TaxDiscount [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.dms.model.validator.DeliveryManagementService [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.rmr.model.validator.RawMaterialManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.pos.model.validator.ChangeTax [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.wms.model.validator.ExpressWMS [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.model.validator.TravelAgencyManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.cash.model.validator.CashManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.consignment.model.validator.ConsignedMaterial [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.tpa.model.validator.ThirdPartyAccess [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.eos.model.validator.ConversionRate [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.eos.model.validator.ExchangeOperations [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.model.validator.FiscalPrinter [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.model.Withholding [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.erpya.lve.model.FinancialBigTransactionTax [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.erpya.lve.model.TaxDiscount [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.dms.model.validator.DeliveryManagementService [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.rmr.model.validator.RawMaterialManagement [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.pos.model.validator.ChangeTax [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.wms.model.validator.ExpressWMS [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.wms.model.validator.ProductValidation [20]
-----------> ModelValidationEngine.loadValidatorClass: client INALCON already exists for class: org.spin.eca49.model.validator.OrderLine [20]
-----------> ModelValidationEngine.loadValidatorClass: client Industrias Maros C.A.  already exists for class: org.spin.eca49.model.validator.OrderLine [20]
-----------> DB.isBuildOK: Error en la versión de la construcción 

El programa asume version de construcción ADempiere, pero la base de datos tiene una versión ${ADEMPIERE_VERSION} 20200706-1035.
Es posible que esto cause errores difíciles de corregir.
Por favor contacte al ADMINISTRADOR. [1]
-----------> MPriceList.getPriceListVersion: None found M_PriceList_ID=0 - 2024-02-22 00:00:00.0 [20]
-----------> MIssue.set_Value: LoggerName - Value too long - truncated to length=60 [20]
===========> CalloutContract.start: start: priceList [20]
java.lang.NullPointerException
	at org.eevolution.context.service.domain.callouts.CalloutContract.priceList(CalloutContract.scala:184)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.compiere.model.CalloutEngine.start(CalloutEngine.java:109)
	at org.compiere.model.GridTab.processCallout(GridTab.java:2719)
	at org.compiere.model.GridTab.lambda$dataNew$1(GridTab.java:1175)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
	at org.compiere.model.GridTab.dataNew(GridTab.java:1175)
	at org.compiere.apps.APanel.cmd_new(APanel.java:1945)
	at org.compiere.apps.APanel.actionPerformed(APanel.java:1750)
	at org.compiere.apps.AppsAction.actionPerformed(AppsAction.java:286)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)

===========> GridTab.processCallout: java.lang.NullPointerException [20]
-----------> MPriceList.getPriceListVersion: None found M_PriceList_ID=0 - 2024-02-22 00:00:00.0 [20]
-----------> MIssue.set_Value: LoggerName - Value too long - truncated to length=60 [20]
===========> CalloutContract.start: start: priceList [20]
java.lang.NullPointerException
	at org.eevolution.context.service.domain.callouts.CalloutContract.priceList(CalloutContract.scala:184)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.compiere.model.CalloutEngine.start(CalloutEngine.java:109)
	at org.compiere.model.GridTab.processCallout(GridTab.java:2719)
	at org.compiere.model.GridTab.lambda$dataNew$1(GridTab.java:1175)
	at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
	at org.compiere.model.GridTab.dataNew(GridTab.java:1175)
	at org.compiere.apps.APanel.cmd_new(APanel.java:1945)
	at org.compiere.apps.APanel.actionPerformed(APanel.java:1750)
	at org.compiere.apps.AppsAction.actionPerformed(AppsAction.java:286)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.AWTEventMulticaster.mouseReleased(AWTEventMulticaster.java:297)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6635)

===========> GridTab.processCallout: java.lang.NullPointerException [20]

@yamelsenih yamelsenih merged commit bd5784b into adempiere:main Nov 2, 2024
1 check passed
@yamelsenih yamelsenih deleted the bugfix/FixNPECalloutContract branch November 2, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosaparadam @yamelsenih