Change Setup.py to use elif statements to avoid doubling requirements #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caternuson
approved these changes
Jan 28, 2025
|
Looks like it worked! |
|
FYI -- on a Pi 5, after installing Blinka 8.52.0 (using the script from the guide in a new venv) it seems to work OK, but then if I use pip to install a circuitptyhon library Somethting appears to still be amiss with pip and RPI.GPIO I have also commented in the forum https://forums.adafruit.com/viewtopic.php?p=1044283#p1044283 |
|
Hmm, that is odd and adds to the mystery. I guess I need to figure out where it's getting that requirement from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes Setup.py to use elif statements to avoid installing both Pi 4 and Pi 5 requirements on Pi 5. This may not fix the problem, but shouldn't break it either.