Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sync server package name to @actual-app/sync-server #4370

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Feb 12, 2025

Aligning the sync server package name with the rest of the workspace.

Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9575b46
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/67b0f159188dd40008c057a2
😎 Deploy Preview https://deploy-preview-4370.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MikesGlitch MikesGlitch marked this pull request as ready for review February 15, 2025 19:56
Copy link
Contributor

coderabbitai bot commented Feb 15, 2025

Walkthrough

The changes update workspace references for the sync-server package across multiple files. The modifications replace the old workspace identifier actual-sync with the new scoped identifier @actual-app/sync-server in several scripts within the package.json files as well as in the Dockerfiles for different environments. These updates occur in the start:server and install:server commands and the build process, ensuring that operations now target the correctly scoped workspace. Additionally, the package name in packages/sync-server/package.json has been updated to reflect the new naming convention.

Possibly related PRs

Suggested labels

:sparkles: Merged

Suggested reviewers

  • youngcw

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1a4c88 and 9575b46.

⛔ Files ignored due to path filters (2)
  • upcoming-release-notes/4370.md is excluded by !**/*.md
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (7)
  • package.json (2 hunks)
  • packages/sync-server/docker/edge-alpine.Dockerfile (1 hunks)
  • packages/sync-server/docker/edge-ubuntu.Dockerfile (1 hunks)
  • packages/sync-server/docker/stable-alpine.Dockerfile (1 hunks)
  • packages/sync-server/docker/stable-ubuntu.Dockerfile (1 hunks)
  • packages/sync-server/package.json (1 hunks)
  • sync-server.Dockerfile (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/sync-server/package.json
⏰ Context from checks skipped due to timeout of 90000ms (13)
  • GitHub Check: test
  • GitHub Check: web
  • GitHub Check: build (macos-latest)
  • GitHub Check: server
  • GitHub Check: build (windows-latest)
  • GitHub Check: typecheck
  • GitHub Check: Analyze
  • GitHub Check: Wait for Netlify build to finish
  • GitHub Check: build (ubuntu-latest)
  • GitHub Check: Build Docker image (alpine)
  • GitHub Check: lint
  • GitHub Check: api
  • GitHub Check: Build Docker image (ubuntu)
🔇 Additional comments (7)
sync-server.Dockerfile (1)

6-6: Update Yarn Workspace Focus Command
The RUN command now correctly targets the new workspace identifier @actual-app/sync-server, ensuring consistency with the new naming convention.

packages/sync-server/docker/stable-ubuntu.Dockerfile (1)

7-7: Consistent Workspace Naming
The update to RUN yarn workspaces focus @actual-app/sync-server --production aligns this Dockerfile with the new package naming convention. The change is clear and consistent with the rest of the workspace updates.

packages/sync-server/docker/stable-alpine.Dockerfile (1)

7-7: Correct Upgrade for Alpine Build
The command now focuses on the correct workspace (@actual-app/sync-server), which is essential for ensuring that the production build pulls the expected dependencies.

packages/sync-server/docker/edge-ubuntu.Dockerfile (1)

7-7: Aligned Workspace Update
The updated RUN command correctly references @actual-app/sync-server, which maintains consistency with the new naming across all environments.

packages/sync-server/docker/edge-alpine.Dockerfile (1)

7-7: Workspace Name Update Verified
The change to RUN yarn workspaces focus @actual-app/sync-server --production is consistent, ensuring that even on edge builds with Alpine the new workspace name is used.

package.json (2)

22-22: Update “start:server” Command to New Scoped Package

The updated script
"start:server": "yarn workspace @actual-app/sync-server start"
accurately reflects the new workspace identifier. This change is consistent with the PR objectives to align sync server package naming.


44-44: Update “install:server” Command for Consistency

The installation command has been updated to
"install:server": "yarn workspaces focus @actual-app/sync-server --production".
This ensures the production build focuses on the correctly scoped sync server, aligning with the overall naming convention update.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MikesGlitch MikesGlitch merged commit 87779d3 into actualbudget:master Feb 16, 2025
22 checks passed
lelemm pushed a commit to lelemm/actual that referenced this pull request Feb 18, 2025
…udget#4370)

* updating sync server to have a consistent package name

* release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants