Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security and Privacy section improved with UI #2639

Merged
merged 6 commits into from
Feb 21, 2025

Conversation

anisha-e10
Copy link
Contributor

@anisha-e10 anisha-e10 commented Feb 20, 2025

Improved, #2598

This PR introduces improvements to the security and privacy UI on the activity page. The changes enhance user experience.

Reference Image (When Recovery State is Disabled) :

enableBackup

Reference Image (When Recovery State is Incomplete) :

providerRecoveryKey

Reference Image (When Recovery State is Enabled) :

backupenableReset

Reference Image ( When Recovery State is Incomplete) :

Note : When allowDisabling is true in backup page.

keyBackupwithReset

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.

Project coverage is 33.29%. Comparing base (7916340) to head (1db62d0).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
app/lib/features/space/widgets/space_toolbar.dart 0.00% 4 Missing ⚠️
.../features/backups/widgets/backup_state_widget.dart 91.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
+ Coverage   33.16%   33.29%   +0.12%     
==========================================
  Files         743      744       +1     
  Lines       48244    48314      +70     
==========================================
+ Hits        16001    16084      +83     
+ Misses      32243    32230      -13     
Flag Coverage Δ
integration-test 43.24% <ø> (-0.09%) ⬇️
unittest 24.12% <91.02%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anisha-e10 anisha-e10 marked this pull request as ready for review February 20, 2025 10:52
Copy link
Contributor

@kumarpalsinh25 kumarpalsinh25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UI improvement!

Code changes look good to me.

Good to have widget testing for SecurityPrivacyWidget and BackupStateWidget.

@anisha-e10 anisha-e10 merged commit e0c1c79 into main Feb 21, 2025
23 checks passed
@anisha-e10 anisha-e10 deleted the anisha/activity-security-privacy-section branch February 21, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

2 participants