Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that app exit on system tray doesn't work in windows #2635

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

bitfriend
Copy link
Contributor

I found Exit app menu of system tray doesn't work in windows.
Will fix it here.

@bitfriend bitfriend added flutter minor This is a changeset with little need for review. t-windows Windows target related issues and tasks labels Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.10%. Comparing base (7916340) to head (fc52224).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2635      +/-   ##
==========================================
- Coverage   33.16%   33.10%   -0.07%     
==========================================
  Files         743      743              
  Lines       48244    48244              
==========================================
- Hits        16001    15970      -31     
- Misses      32243    32274      +31     
Flag Coverage Δ
integration-test 43.16% <ø> (-0.16%) ⬇️
unittest 23.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitfriend bitfriend force-pushed the issue198_cleanup-periodically branch from 7ce479e to fc817e1 Compare February 19, 2025 09:46
@bitfriend
Copy link
Contributor Author

This callback doesn't work in windows.
This comment was helpful to me.

@bitfriend
Copy link
Contributor Author

Now user can exit app via system tray in windows.

@bitfriend bitfriend marked this pull request as ready for review February 19, 2025 10:33
@bitfriend bitfriend merged commit 8353c06 into acterglobal:main Feb 19, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flutter minor This is a changeset with little need for review. t-windows Windows target related issues and tasks
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

1 participant