New default Link behavior setting #2634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there 👋,
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2634 +/- ##
==========================================
- Coverage 33.23% 33.21% -0.02%
==========================================
Files 742 742
Lines 48154 48182 +28
==========================================
+ Hits 16003 16005 +2
- Misses 32151 32177 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kumarpalsinh25
approved these changes
Feb 19, 2025
Comment on lines
-10
to
-14
| if (url == null || !url.hasAuthority) { | ||
| _log.info('Opening internally: $url'); | ||
| // not a valid URL, try local routing | ||
| await context.push(target); | ||
| return true; |
There was a problem hiding this comment.
What is !url.hasAuthority which is removed in new code?
And internal url opening code also removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor UX improvement allowing the user to configure what should happen if a link is clicked: by default it opens with the system behavior but you can also ask it to just put it into the clipboard now.
what-to-do-wth-links.mp4