Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long path issue of matrix sdk in windows #2613

Merged
merged 4 commits into from
Feb 19, 2025

Conversation

bitfriend
Copy link
Contributor

@bitfriend bitfriend commented Feb 18, 2025

I found upgrade of matrix-sdk has the following issue in windows.

[cargo-make] INFO - cargo make 0.37.24
[cargo-make] WARN - Unable to parse Cargo.toml via cargo-metadata, fallbacking. `cargo metadata` exited with an error: error: failed to get `matrix-sdk` as a dependency of package `acter v0.1.0 (D:\falseman\2022-05-18\effektio\native\acter)`

Caused by:
  failed to load source for dependency `matrix-sdk`

Caused by:
  Unable to update https://github.com/matrix-org/matrix-rust-sdk#f33d1046

  path too long: 'F:/rust-workspace/.cargo/git/checkouts/matrix-rust-sdk-1f4927f82a3d27bb/f33d104/crates/matrix-sdk-crypto/src/session_manager/group_sessions/snapshots/matrix_sdk_crypto__session_manager__group_sessions__share_strategy__tests__dehydrated_device__prepare_machine_with_dehydrated_device_of_verification_violation_user.snap'; class=Filesystem (30)

Will fix this issue.

@bitfriend bitfriend added the rust label Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 33.18%. Comparing base (8353c06) to head (9d62fed).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
native/file-event-cache/src/queued.rs 0.00% 19 Missing ⚠️
native/file-event-cache/src/lib.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
- Coverage   33.22%   33.18%   -0.04%     
==========================================
  Files         743      743              
  Lines       48244    48274      +30     
==========================================
- Hits        16027    16022       -5     
- Misses      32217    32252      +35     
Flag Coverage Δ
integration-test 43.36% <0.00%> (-0.10%) ⬇️
unittest 23.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitfriend
Copy link
Contributor Author

bitfriend commented Feb 18, 2025

This PR is using our forked matrix-sdk that contains the simple patch.

That patch was generated by running of cargo insta test and cargo insta review after turning off prepend_module_to_snapshot.

@gnunicorn
Copy link
Contributor

@bitfriend I see this is mainly about using a branch of a fork of ours. Did you also raise the issue/PR with the original repo?

@bitfriend
Copy link
Contributor Author

Already raised PR and in reviewing.
They asked me to change the codebase as possible as less.
And @richvdh let me know about cargo insta test.
Will finish that PR soon.

@bitfriend
Copy link
Contributor Author

@gnunicorn This PR is using our forked matrix-sdk that contains the small change from your sdk upgrade.
I think if my PR to matrix sdk is approved, we would replace acterglobal with matrix-org easily because this change is tiny.
What about approve of this PR for now?
Now I am suffering due to long path issue in windows.

@bitfriend
Copy link
Contributor Author

matrix-sdk approved my PR.
Now we are using matrix org sdk not acterglobal sdk.

@bitfriend bitfriend merged commit 029d699 into acterglobal:main Feb 19, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

2 participants