Introducing Socialised Stories Updates #2537

kumarpalsinh25 · 2025-01-30T11:39:32Z

Fixes, #2502

Note to reviewers :

This PR gets slightly bigger but there were no other option to reduce down this work in smaller pieces so let me try to explain as much as I can this PR Description and Code comments.
Many of changes are related to Naming changes.

Introducing new type of Acter Update which is called Stories

Technically Boost and Story are mostly same expect below key difference.
STORIES : "Everyone can see and It will disappears in 14 days",
BOOST : "Important News. Which also sends a push notification to space members",

Summary of changes

1) Removed space selection from post editor screen:

As Boost/Stories action items are independent from space selection, I have remove space selection option from editor window.

Space.selection.removal.from.editor.mov

2) Introducing all new `PostTo` screen:

As now you there are two type of Updates which is Stories and Boost, so upon setting update different slides from post editor you will be navigating to new PostTo screen where you need to do,

Space selection
Post Type selection which is Stories or Boost (This options are enabled based on the selected space permissions)

Post.To.mov

3) Changes in View Updates:

Updates filter tab added at the top to filters it based on the type.
For Boost Update : you will will space avatar in bottom right and Space Name and Post time in bottom left side
For Story Update : you will will user avatar (who posted story) in bottom right and User Name and Space name in bottom left side.

Update.view.mov

Update.Grid.View.mov

4) Overview of key code changes:

Created different abstract classes to combine news and story related stuff in one.

…to routing

github-actions · 2025-01-30T11:39:54Z

Hey there 👋,
and thanks for the contribution. But it seems like you forgot to

📰 Add a markdown file in .changes/ explaining what changed

codecov · 2025-01-30T11:41:28Z

Codecov Report

Attention: Patch coverage is 21.98697% with 479 lines in your changes missing coverage. Please review.

Project coverage is 33.16%. Comparing base (029d699) to head (179dc7a).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...res/news/pages/add_news/add_news_post_to_page.dart	0.00%	92 Missing ⚠️
app/lib/features/news/model/type/update_entry.dart	1.88%	52 Missing ⚠️
app/lib/features/news/actions/submit_story.dart	0.00%	32 Missing ⚠️
...pp/lib/features/news/actions/make_image_slide.dart	0.00%	31 Missing ⚠️
...res/news/providers/news_post_editor_providers.dart	6.06%	31 Missing ⚠️
...pp/lib/features/news/actions/make_video_slide.dart	0.00%	27 Missing ⚠️
app/lib/features/news/actions/make_text_slide.dart	0.00%	26 Missing ⚠️
app/lib/features/news/model/type/update_slide.dart	0.00%	26 Missing ⚠️
...pp/lib/features/news/providers/news_providers.dart	28.57%	25 Missing ⚠️
...features/news/widgets/news_item/news_side_bar.dart	58.62%	24 Missing ⚠️
... and 18 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
- Coverage   33.20%   33.16%   -0.05%     
==========================================
  Files         743      753      +10     
  Lines       48274    48660     +386     
==========================================
+ Hits        16029    16136     +107     
- Misses      32245    32524     +279

Flag	Coverage Δ
integration-test	`43.34% <0.00%> (-0.05%)`	⬇️
unittest	`23.96% <22.02%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts: # app/lib/l10n/app_en.arb

# Conflicts: # app/lib/features/news/providers/news_post_editor_providers.dart

# Conflicts: # app/lib/features/news/providers/news_post_editor_providers.dart # app/lib/features/news/widgets/news_grid_view.dart # app/lib/features/news/widgets/news_item/news_item.dart # app/lib/features/news/widgets/news_item_slide/image_slide.dart # app/lib/features/news/widgets/news_item_slide/news_slide_item.dart # app/lib/features/news/widgets/news_item_slide/video_slide.dart # app/lib/l10n/app_en.arb # app/test/features/update/image_slide_widget_test.dart # app/test/features/update/video_slide_widget_test.dart

kumarpalsinh25 · 2025-02-21T06:12:09Z

app/integration_test/tests/updates.dart

@@ -33,16 +33,15 @@ extension ActerNews on ConvenientTest {
  }

  Future<void> toggleBackgroundColor() async {
-    final slideBackgroundColorKey =
-        find.byKey(NewsUpdateKeys.slideBackgroundColor);
+    final slideBackgroundColorKey = find.byKey(UpdateKeys.slideBackgroundColor);


Only name changes from NewsUpdateKeys to UpdateKeys

kumarpalsinh25 · 2025-02-21T06:12:48Z

app/integration_test/tests/updates.dart

@@ -72,39 +71,39 @@ extension ActerNews on ConvenientTest {
    final imageFile = await convertAssetImageToXFile(
      filepath ?? 'assets/images/update_onboard.png',
    );
-    final slide = NewsSlideItem(
-      type: NewsSlideType.image,
+    final slide = UpdateSlideItem(


Only name changes from NewsSlideItem to UpdateSlideItem

kumarpalsinh25 · 2025-02-21T06:14:12Z

app/lib/common/utils/routes.dart

@@ -28,6 +28,7 @@ enum Routes {
  update('/updates/:updateId([^/]+)'),
  updateList('/updateList'),
  actionAddUpdate('/actions/addUpdate'),
+  actionAddUpdatePostTo('/actions/addUpdate/PostTo'),


Added new PostTo screen as show-case in PR Description

kumarpalsinh25 · 2025-02-21T06:14:57Z

app/lib/features/comments/types.dart

@@ -57,11 +58,11 @@ extension TaskCommentsManagerProviderExtension on Task {
      TaskCommentsManagerProvider(this);
 }

-class NewsEntryCommentsManagerProvider implements CommentsManagerProvider {
-  final NewsEntry inner;
+class UpdateEntryCommentsManagerProvider implements CommentsManagerProvider {


Naming changes only.

kumarpalsinh25 · 2025-02-21T06:16:17Z

app/lib/features/news/actions/make_image_slide.dart

+import 'package:flutter_riverpod/flutter_riverpod.dart';
+import 'package:mime/mime.dart';
+
+Future<NewsSlideDraft> makeImageSlideForNews(


No logical changes. Just copied logic from previous implementation and used it based on the post type.

kumarpalsinh25 · 2025-02-21T06:18:48Z

app/lib/features/news/model/type/update_slide.dart

@@ -0,0 +1,65 @@
+import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';
+
+abstract class UpdateSlide {


Generalised abstract class creation.

kumarpalsinh25 · 2025-02-21T06:19:39Z

app/lib/features/news/pages/add_news/add_news_post_to_page.dart

+
+enum PostTypeSelection { story, boost, none }
+
+class AddNewsPostToPage extends ConsumerStatefulWidget {


All new PostTo page for space selection and post type selection.

kumarpalsinh25 · 2025-02-21T06:20:22Z

app/lib/features/news/providers/news_post_editor_providers.dart

-    NewsSlideItem? selectedNewsSlide = state.currentNewsSlide;
-    selectedNewsSlide?.backgroundColor = getRandomElement(newsPostColors);
-    state = state.copyWith(currentNewsSlide: selectedNewsSlide);
+    UpdateSlideItem? selectedUpdateSlide = state.currentUpdateSlide;


Naming changes only.

kumarpalsinh25 · 2025-02-21T06:20:38Z

app/lib/features/news/providers/news_providers.dart

 import 'package:riverpod/riverpod.dart';

+//EVENT FILTERS
+enum UpdateFilters {


Added filters for updates

kumarpalsinh25 · 2025-02-21T06:21:41Z

app/lib/features/news/widgets/news_item_slide/news_filter_buttons.dart

+import 'package:flutter_gen/gen_l10n/l10n.dart';
+import 'package:flutter_riverpod/flutter_riverpod.dart';
+
+class NewsFilterButtons extends ConsumerWidget {


Updates Filter Buttons UI.

Created PostTo page for Add new flow and did required change related …

b050510

…to routing

kumarpalsinh25 and others added 27 commits February 3, 2025 12:44

Minor Fix

5d0316a

PostTo screen design draft

c3ec2a0

Merge branch 'main' into kumar/stories-update

a8ec33d

# Conflicts: # app/lib/l10n/app_en.arb

Update lang

a90e2bc

Added Boost and Stories selection options

2050742

Manage canPostBoost permission based on the selected space

832cb22

Submit story implementation

a2efec1

Generalise code of MsgDraft

6f659d5

Merge branch 'main' into kumar/stories-update

43d8f3a

# Conflicts: # app/lib/features/news/providers/news_post_editor_providers.dart

draft of abstract types

522c1ab

more draft of slides

91ffef6

stories providers draft

ef7157a

Updated abstract class for News and Story

8c7db75

News and Story abstract class related changes

fab262e

Fixed lint errors

f8c409b

Fixed lint errors

f444715

Fixed lint errors

9337f52

Added stories notifier and used it in updateList provider

16210c6

More changes related to naming

4d19d34

Lint fix

9572bb2

Added User name and Avtar for story update

b20c9dd

added sorting to update list

42a2068

Optimised providers

e18e30a

Added Update Filter provider

4a247e9

Added filter chips for updates

038ae0d

Changes in FilterChip design

c91fcc7

kumarpalsinh25 added 7 commits February 20, 2025 17:27

Corrections in providers

2a018c3

Code improvements

dd85516

Added missing L10n strings

30082f6

Merge branch 'main' into kumar/stories-update

f246177

Added post update validations

d8e8c11

Minor naming corrections

8a78093

Minor UI correction

2c4a497

kumarpalsinh25 commented Feb 21, 2025

View reviewed changes

bitfriend and others added 5 commits February 21, 2025 15:22

Change the default of story permission to true

01786a8

Added secondary can permission check in Select space drawer

048ee99

Updated default intilisation

b8acaa0

Fixes widget testing

f97e6d3

Fixed lint error

179dc7a

kumarpalsinh25 marked this pull request as ready for review February 21, 2025 12:02

kumarpalsinh25 requested review from gnunicorn, anisha-e10 and gtalha07 February 21, 2025 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introducing Socialised Stories Updates #2537

Introducing Socialised Stories Updates #2537

kumarpalsinh25 commented Jan 30, 2025 •

edited

Loading

github-actions bot commented Jan 30, 2025

codecov bot commented Jan 30, 2025 •

edited

Loading

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

kumarpalsinh25 Feb 21, 2025

		@@ -0,0 +1,65 @@
		import 'package:acter_flutter_sdk/acter_flutter_sdk_ffi.dart';

		abstract class UpdateSlide {


		enum PostTypeSelection { story, boost, none }

		class AddNewsPostToPage extends ConsumerStatefulWidget {

Introducing Socialised Stories Updates #2537

Are you sure you want to change the base?

Introducing Socialised Stories Updates #2537

Conversation

kumarpalsinh25 commented Jan 30, 2025 • edited Loading

Introducing new type of Acter Update which is called Stories

Summary of changes

1) Removed space selection from post editor screen:

2) Introducing all new PostTo screen:

3) Changes in View Updates:

4) Overview of key code changes:

github-actions bot commented Jan 30, 2025

codecov bot commented Jan 30, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kumarpalsinh25 commented Jan 30, 2025 •

edited

Loading

2) Introducing all new `PostTo` screen:

codecov bot commented Jan 30, 2025 •

edited

Loading