Inline Error Button with Retry for chat images #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there 👋,
|
17 tasks
kumarpalsinh25
approved these changes
Aug 28, 2024
Comment on lines
+36
to
+50
| final mediaPath = | ||
| (await _convo!.mediaPath(messageInfo.messageId, false)).text(); | ||
|
|
||
| if (mediaPath != null) { | ||
| state = state.copyWith( | ||
| mediaFile: File(mediaPath.text()!), | ||
| videoThumbnailFile: videoThumbnailFile, | ||
| mediaFile: File(mediaPath), | ||
| videoThumbnailFile: null, | ||
| mediaChatLoadingState: const MediaChatLoadingState.loaded(), | ||
| ); | ||
| final videoThumbnailFile = await getThumbnailData(mediaPath); | ||
| if (videoThumbnailFile != null) { | ||
| if (state.mediaFile?.path == mediaPath) { | ||
| state = state.copyWith(videoThumbnailFile: videoThumbnailFile); | ||
| } | ||
| } |
There was a problem hiding this comment.
Assuming that this changes are for updating change in 2 separate action for file and thumb so that one can not have to wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images in chat media had a really ugly illegible error message (see https://github.com/acterglobal/a3-meta/issues/455 ). Built on top of #2089 this adds an inline icon instead that upon click opens our new ErrorDialog with the option to retry or report it as a bug.
Fixes https://github.com/acterglobal/a3-meta/issues/455 .