Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : Space Details - Add Task Inline option not working #2094

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fixes : Space Details - Add Task Inline option not working #2094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions app/lib/features/tasks/widgets/task_items_list_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,21 +14,27 @@ import 'package:logging/logging.dart';

final _log = Logger('a3::tasks::widgets::list');

class TaskItemsListWidget extends ConsumerWidget {
class TaskItemsListWidget extends ConsumerStatefulWidget {
final TaskList taskList;
final bool showCompletedTask;

TaskItemsListWidget({
const TaskItemsListWidget({
super.key,
required this.taskList,
this.showCompletedTask = false,
});

@override
ConsumerState<ConsumerStatefulWidget> createState() =>
TaskItemsListWidgetState();
}

class TaskItemsListWidgetState extends ConsumerState<TaskItemsListWidget> {
final ValueNotifier<bool> showInlineAddTask = ValueNotifier(false);

@override
Widget build(BuildContext context, WidgetRef ref) {
final overviewLoader = ref.watch(taskItemsListProvider(taskList));
Widget build(BuildContext context) {
final overviewLoader = ref.watch(taskItemsListProvider(widget.taskList));
return overviewLoader.when(
data: (overview) => taskData(context, overview),
error: (e, s) {
Expand All @@ -41,6 +47,7 @@ class TaskItemsListWidget extends ConsumerWidget {

Widget taskData(BuildContext context, TasksOverview overview) {
return Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.start,
children: [
openTasksEntries(context, overview),
Expand All @@ -60,21 +67,21 @@ class TaskItemsListWidget extends ConsumerWidget {
for (final taskId in overview.openTasks)
TaskItem(
onTap: () => showInlineAddTask.value = false,
taskListId: taskList.eventIdStr(),
taskListId: widget.taskList.eventIdStr(),
taskId: taskId,
),
],
);
}

Widget inlineAddTask() {
final taskListEventId = taskList.eventIdStr();
final taskListEventId = widget.taskList.eventIdStr();
return ValueListenableBuilder(
valueListenable: showInlineAddTask,
builder: (context, value, child) {
return value
? _InlineTaskAdd(
taskList: taskList,
taskList: widget.taskList,
cancel: () => showInlineAddTask.value = false,
)
: Container(
Expand All @@ -94,7 +101,7 @@ class TaskItemsListWidget extends ConsumerWidget {
}

Widget doneTasksEntries(BuildContext context, TasksOverview overview) {
if (overview.doneTasks.isEmpty || !showCompletedTask) {
if (overview.doneTasks.isEmpty || !widget.showCompletedTask) {
return const SizedBox.shrink();
}

Expand All @@ -112,7 +119,7 @@ class TaskItemsListWidget extends ConsumerWidget {
),
for (final taskId in overview.doneTasks)
TaskItem(
taskListId: taskList.eventIdStr(),
taskListId: widget.taskList.eventIdStr(),
taskId: taskId,
onTap: () => showInlineAddTask.value = false,
),
Expand Down
Loading