Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove affiliation from dialog #4374

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove affiliation from dialog #4374

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aee1994
Remove affiliation from dialog
mjpost Jan 9, 2025
ab2a338
Fix stray commas in JSON
mjpost Jan 9, 2025
69342e7
Block too-long URLs (#4135)
mjpost Jan 9, 2025
d2aa21c
Merge remote-tracking branch 'origin/master' into remove-affiliations
mjpost Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hugo/layouts/papers/single.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@

const url = baseurl + `&title=${encodeURIComponent(issue_title)}&assignee=${encodeURIComponent(who)}&labels=${encodeURIComponent(labels)}&data=` + encodeURIComponent(param_string);

// Display an error if the URL length string is too long
if (url.length > 2000) {
alert(`The correction string URL is too long to submit (${url.length} chars). Please open a manual correction request at https://github.com/acl-org/acl-anthology/issues/new`);
return;
}

window.open(url, "_blank");
}
</script>
Expand Down