Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NDB_BVL_Battery] isDoubleDataEntryEnabledForInstrument should consider CohortID #9705

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[NDB_BVL_Battery] isDoubleDataEntryEnabledForInstrument should consider CohortID #9705

wants to merge 4 commits into from

Conversation

skarya22
Copy link
Contributor

Brief summary of changes

  • Make isDoubleDataEntryEnabledForInstrument consider CohortID as there can be instances in the test_battery with the same instrument and visit_label but different CohortID

Testing instructions (if applicable)

  1. Try adding an instrument in two different cohorts with the same visit_label
  2. Confirm you can open it and do not face an error with the function.

Link(s) to related issue(s)

  • Found in testing round

@skarya22 skarya22 added Module: instrument_list PR or issue related to instrument_list module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 14, 2025
@skarya22 skarya22 added this to the 27.0.0 milestone Mar 14, 2025
kongtiaowang
kongtiaowang approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@kongtiaowang kongtiaowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skarya22 skarya22 changed the title [NDB_BVL_Battery] isDoubleDataEntryEnabledForInstrument should consid…er CohortID [NDB_BVL_Battery] isDoubleDataEntryEnabledForInstrument should consider CohortID Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kongtiaowang kongtiaowang kongtiaowang approved these changes

Assignees

@kongtiaowang kongtiaowang

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: instrument_list PR or issue related to instrument_list module
Projects
None yet
Milestone
27.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skarya22 @kongtiaowang