Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data_dict (legacy)] fix description not updating upon refresh #9681

Merged
merged 2 commits into from
Mar 27, 2025
Merged

[data_dict (legacy)] fix description not updating upon refresh #9681

merged 2 commits into from
Mar 27, 2025

Conversation

shonibare
Copy link
Contributor

fixes #9618

To Test:

  1. Log in as a user with permission data_dict_edit.
  2. Edit the description of any field in the search result table.
  3. Reload the page in the browser.
  4. See the new description has been saved

@shonibare shonibare added Language: PHP PR or issue that update PHP code Module: datadict PR or issue related to (old) datadict module 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 5, 2025
@shonibare shonibare added this to the 27.0.0 milestone Mar 11, 2025
GeorgeMurad
GeorgeMurad approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@GeorgeMurad GeorgeMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driusan driusan merged commit 33dfaef into aces:main Mar 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMurad GeorgeMurad GeorgeMurad approved these changes

Assignees

@GeorgeMurad GeorgeMurad

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Language: PHP PR or issue that update PHP code Module: datadict PR or issue related to (old) datadict module
Projects
None yet
Milestone
27.0.0
Development

Successfully merging this pull request may close these issues.

[data_dict (legacy)] Edit description does not work
3 participants
@shonibare @GeorgeMurad @driusan