[dataquery] Add instrument flags to instruments query engine #9529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
force-pushed
the
DQTFlagColumns
branch
from
217ad4f to
ef0f9e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds instrument flags to the data that is bulk loaded by bulkLoadInstanceData and uses that to address the low hanging fruit of #9372 of including administration flags in the data query tool.
It does not address the DDE and conflict related fields that are in the CouchDB import script because we should investigate if those make sense in the instruments query engine or if it's possible to have those provided by the conflict resolver module rather than the instruments module, as they are more related to that module.