Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[media] Inaccurate instructions on Upload tab #9721

Open
jeffersoncasimir opened this issue Mar 19, 2025 · 6 comments
Open

[media] Inaccurate instructions on Upload tab #9721

jeffersoncasimir opened this issue Mar 19, 2025 · 6 comments
Assignees
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: media PR or issue related to media module
Milestone

Comments

@jeffersoncasimir
Copy link
Contributor

jeffersoncasimir commented Mar 19, 2025

The Upload tab says: File name must begin with [PSCID]_[Visit Label]_[Instrument]

This is confusing and should probably more accurately reflect truth, like the TestPlan which says:

File name should always start with [PSCID]_[Visit Label]. If an instrument is selected, the file name should should start with [PSCID]_[Visit Label]_[Instrument].

@jeffersoncasimir jeffersoncasimir added 27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: media PR or issue related to media module labels Mar 19, 2025
@jeffersoncasimir jeffersoncasimir added this to the 27.0.0 milestone Mar 19, 2025
@adamdaudrich adamdaudrich self-assigned this Mar 21, 2025
@adamdaudrich
Copy link
Collaborator

adamdaudrich commented Mar 21, 2025

Yes I find it confusing as well.. how about:

Please name your file using the following format: PSCID_Visit Label_Instrument name.ext' For example: ABC123_V1_bmi.mp4`.
Other naming formats will not be accepted. File can not exceed 2048MB (2GB)

@adamdaudrich
Copy link
Collaborator

i got a too large error here for a file that is 35 bytes
-rw-rw-r-- 1 adam adam 35 Mar 21 10:37 DCC090_V1_bmi.pdf

Image

@adamdaudrich
Copy link
Collaborator

yeah "begins with or 'starts with' is a bit confusing.
because the file name starts with ABC123

so the error throw could say:
'Your filename base name should be ROM162_V6_bmi followed by the file extension
for example ABC123_V1_bmi.mp4

Image

@adamdaudrich
Copy link
Collaborator

this is all ux stuff but

instead of override I think the intention is overwrite
Image

also I think the word 'imaginary' is not the right meaning here.

Maybe something like:
The file was not overwritten

@adamdaudrich
Copy link
Collaborator

how about this

Image

I'll for the file size server config to be resolved before issuing the PR, because there is another fix to do that depends on my getting past that gate

@jeffersoncasimir
Copy link
Contributor Author

@adamdaudrich I like this improvement.

My main issue is that the instructions (the Note) uses the word "must" without specifying that the instrument is optional.

It appears that the file only needs to begin with this and it does not have to be the entire file name. It seems like MTL023_V1_mri_parameter_form_123.txt would also be valid. Source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: media PR or issue related to media module
Projects
None yet
Development

No branches or pull requests

2 participants