[media] Instrument not parsed/linked

[jeffersoncasimir]

Discovered during round 2 of testing.

When uploading a file suffixed with _bmi or _aosi (only two tested), it does not get assigned the corresponding "Instrument" field, or at least, does not appear to on the front-end.

Edit: This is incorrect and parsing/auto-linking was never expected

[sruthymathew123]

@jeffersoncasimir @driusan

I took a look at this issue. The media module expects the instrument to be selected in order to properly parse the file and assign it to the corresponding instrument. I think media module supports non instrument related files also to get uploaded.

I checked hbcd/ibis code base with parser instruments; it is always sets the instrument value to properly parse the instrument file.

See below ex:

$query = [
                      'session_id'  => $this->getSessionID(),
                      'instrument'  => $this->table,
		      'date_taken'  => $dateTaken,
		      'comments'    => $otherComments,
                      'file_name'   => $file->getDestinationFilename(),
                      'file_type'   => 'DAS_SA',
                      'data_dir'    => $mediaPath,
		      'uploaded_by' => $user->getData('UserID'),
            ];

            // File alread exists in media module: update
            if (!is_null($mediaID)) {
                $db->update('media', $query, array('ID' => $mediaID));
            // File does not exist in media module: insert new
            } else {
                $db->insert('media', $query);
            }

[jeffersoncasimir]

@sruthymathew123 I gave it another look I am going to open a new issue to request a change to the instructions on the Upload tab, to match the TestPlan and reality.

The Upload tab says: File name must begin with [PSCID]_[Visit Label]_[Instrument]

I can confirm that it works as normal when selecting an instrument from the dropdown:

Please close this issue once acknowledged, @driusan

[adamdaudrich]

related to #9721