Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] PUT/PATCH requests not updating instrument flags #7916

Open
AlexandraLivadas opened this issue Dec 14, 2021 · 0 comments
Open

[API] PUT/PATCH requests not updating instrument flags #7916

AlexandraLivadas opened this issue Dec 14, 2021 · 0 comments
Assignees
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Area: API PR or issue related to the API Category: Bug PR or issue that aims to report or fix a bug Module: api PR or issue related to api module
Milestone

Comments

@AlexandraLivadas
Copy link
Contributor

AlexandraLivadas commented Dec 14, 2021

Describe the bug
Both the PUT and PATCH requests used to update an instrument's flag values (and DDE flag values) are returning internal server errors and not correctly updating the values
The 4 requests in question are:

  • PUT /candidates/{candid}/{visit}/instruments/{instrument}/flags
  • PATCH /candidates/{candid}/{visit}/instruments/{instrument}/flags
  • PUT /candidates/{candid}/{visit}/instruments/{instrument}/dde/flags
  • PATCH /candidates/{candid}/{visit}/instruments/{instrument}/dde/flags

To Reproduce

  1. Go to the API Documentation module and scroll down to any of the above commands
  2. Click on "Try it out" and enter a CandID, visit label, and instrument name. You can use the above GET requests to get a candidate and the list of their visits and instruments
  3. Fill in the request body with the flag data you would like to update
  4. Click on "Execute" and see internal server error
  5. Go to the GET request /candidates/{candid}/{visit}/instruments/{instrument}/flags (right above the PUT request) and insert the same CandID, visit label, and instrument. Execute and see that the flag data was not updated.

What did you expect to happen?
The flag information for that candidate's instrument should be updated and there should be no error.

@AlexandraLivadas AlexandraLivadas added Category: Bug PR or issue that aims to report or fix a bug Area: API PR or issue related to the API 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Dec 14, 2021
@driusan driusan added the Module: api PR or issue related to api module label Jan 21, 2025
@driusan driusan added this to the 27.0.0 milestone Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Area: API PR or issue related to the API Category: Bug PR or issue that aims to report or fix a bug Module: api PR or issue related to api module
Projects
Status: No status
Development

No branches or pull requests

4 participants