Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements for mri_parameter_form should be documented #4670

Open
driusan opened this issue May 22, 2019 · 1 comment
Open

Requirements for mri_parameter_form should be documented #4670

driusan opened this issue May 22, 2019 · 1 comment
Assignees
Labels
Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Priority: High PR or issue should be prioritised over others for review and testing State: Needs documentation PR that needs a more exhaustive documentation to proceed State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed
Milestone

Comments

@driusan
Copy link
Collaborator

driusan commented May 22, 2019

Some places in the code (statistics, qc module off the top of my head) make assumptions about an instrument named "mri_parameter_form" being collected, and that that instrument has columns which match the scan_type table such as T1W_Scan_Done in order to assess whether the data should be there.

These requirements/assumptions should be documented (and perhaps the form turned into a module of some sort instead of an otherwise plain instrument.)

@johnsaigle johnsaigle added 21.0.0 Testing Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) State: Needs documentation PR that needs a more exhaustive documentation to proceed labels May 22, 2019
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed label Jan 8, 2020
@driusan driusan added the Priority: High PR or issue should be prioritised over others for review and testing label Jan 21, 2025
@driusan driusan modified the milestones: 28.0.0, 27.0.0 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Documentation PR or issue that aims to improve the documentation (test plans, wiki, comments...) Priority: High PR or issue should be prioritised over others for review and testing State: Needs documentation PR that needs a more exhaustive documentation to proceed State: Stale PR that has had no recent activity, needs to be triaged for review or closure to proceed
Projects
None yet
Development

No branches or pull requests

4 participants