Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/run_push_imaging_files_to_s3_pipeline.py #1241

Open
7 tasks
cmadjar opened this issue Mar 14, 2025 · 0 comments
Open
7 tasks

python/run_push_imaging_files_to_s3_pipeline.py #1241

cmadjar opened this issue Mar 14, 2025 · 0 comments
Assignees
Labels
27.0-testing Area: CI PR or issue related to continuous integration, including automated tests and static checks

Comments

@cmadjar
Copy link
Collaborator

cmadjar commented Mar 14, 2025

Implement automated testing

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py without the -u
    => should print [ERROR ] argument --upload_id is required

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py -u <UPLOAD ID> on an invalid Upload ID
    => should print [ERROR ] Did not find an entry in mri_upload associated with 'UploadID' 1666

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py -u <UPLOAD ID> with the S3 config settings not set in database_config.py

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py -u <UPLOAD ID> with incorrect S3 authentication settings in database_config.py

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py -u <UPLOAD ID> with the incorrect S3 bucket name in database_config.py

Manual testing

  • run run_push_imaging_files_to_s3_pipeline.py -h
    => should print the help of the script. Make sure the help documentation is up to date.

  • run run_push_imaging_files_to_s3_pipeline.py -p database_config.py -u <UPLOAD ID> on a valid Upload ID and ensure the files has been properly pushed to the S3 bucket

Bugs found:

@cmadjar cmadjar added Area: CI PR or issue related to continuous integration, including automated tests and static checks 27.0-testing labels Mar 14, 2025
@cmadjar cmadjar self-assigned this Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27.0-testing Area: CI PR or issue related to continuous integration, including automated tests and static checks
Projects
None yet
Development

No branches or pull requests

1 participant