This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

get_analysis and analysis_modules with instances is confusing #73

Open

unixfreak0037 opened this issue Mar 9, 2020 · 0 comments

Assignees

Labels

Collaborator

unixfreak0037 commented Mar 9, 2020

If you're dealing with an analysis module that is using "instances",
then instead of this

analysis = observable.get_analysis(self.generated_analysis_type)

you have to do this

analysis = observable.get_analysis(self.generated_analysis_type, instance=self.instance)

That should be taken care of in behind the scenes instead of forcing the developer to figure that out.

unixfreak0037 added the refactoring label

unixfreak0037 self-assigned this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.