refactor: code style, types and tests #1
oliviareichlvalidate.yml
on: push
Check changed files
6s
Matrix: Validate
Build and deploy
/
...
/
deploy
Annotations
10 errors, 6 warnings, and 1 notice
|
Validate (20.x, ubuntu-latest)
Testing stopped early after 10 maximum allowed failures.
|
|
[chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link:
e2e/tests/app/app.test.ts#L142
1) [chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link ───
Error: Timed out 5000ms waiting for expect(locator).toBeFocused()
Locator: getByRole('link', { name: 'Skip to main content' })
Expected: focused
Received: <element(s) not found>
Call log:
- expect.toBeFocused with timeout 5000ms
- waiting for getByRole('link', { name: 'Skip to main content' })
140 |
141 | await indexPage.page.keyboard.press("Tab");
> 142 | await expect(indexPage.skipLink).toBeFocused();
| ^
143 |
144 | await indexPage.skipLink.click();
145 | await expect(indexPage.mainContent).toBeFocused();
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:142:36
|
|
[chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link:
e2e/tests/app/app.test.ts#L142
1) [chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link ───
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeFocused()
Locator: getByRole('link', { name: 'Skip to main content' })
Expected: focused
Received: <element(s) not found>
Call log:
- expect.toBeFocused with timeout 5000ms
- waiting for getByRole('link', { name: 'Skip to main content' })
140 |
141 | await indexPage.page.keyboard.press("Tab");
> 142 | await expect(indexPage.skipLink).toBeFocused();
| ^
143 |
144 | await indexPage.skipLink.click();
145 | await expect(indexPage.mainContent).toBeFocused();
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:142:36
|
|
[chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link:
e2e/tests/app/app.test.ts#L142
1) [chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link ───
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toBeFocused()
Locator: getByRole('link', { name: 'Skip to main content' })
Expected: focused
Received: <element(s) not found>
Call log:
- expect.toBeFocused with timeout 5000ms
- waiting for getByRole('link', { name: 'Skip to main content' })
140 |
141 | await indexPage.page.keyboard.press("Tab");
> 142 | await expect(indexPage.skipLink).toBeFocused();
| ^
143 |
144 | await indexPage.skipLink.click();
145 | await expect(indexPage.mainContent).toBeFocused();
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:142:36
|
|
[chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element:
e2e/tests/app/app.test.ts#L152
2) [chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('html')
Expected string: "en"
Received string: ""
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('html')
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
150 | const { indexPage } = await createIndexPage(locale);
151 | await indexPage.goto();
> 152 | await expect(indexPage.page.locator("html")).toHaveAttribute("lang", locale);
| ^
153 | }
154 | });
155 | });
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:152:49
|
|
[chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element:
e2e/tests/app/app.test.ts#L152
2) [chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('html')
Expected string: "en"
Received string: ""
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('html')
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
150 | const { indexPage } = await createIndexPage(locale);
151 | await indexPage.goto();
> 152 | await expect(indexPage.page.locator("html")).toHaveAttribute("lang", locale);
| ^
153 | }
154 | });
155 | });
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:152:49
|
|
[chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element:
e2e/tests/app/app.test.ts#L152
2) [chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('html')
Expected string: "en"
Received string: ""
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('html')
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
- locator resolved to <html data-capo="" class="light" data-ui-color-scheme="light">…</html>
- unexpected value "null"
150 | const { indexPage } = await createIndexPage(locale);
151 | await indexPage.goto();
> 152 | await expect(indexPage.page.locator("html")).toHaveAttribute("lang", locale);
| ^
153 | }
154 | });
155 | });
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/app.test.ts:152:49
|
|
[chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url:
e2e/tests/app/metadata.test.ts#L16
3) [chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url ─────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('link[rel="canonical"]')
Expected string: "http://localhost:3000/en"
Received: <element(s) not found>
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('link[rel="canonical"]')
14 |
15 | const canonicalUrl = indexPage.page.locator('link[rel="canonical"]');
> 16 | await expect(canonicalUrl).toHaveAttribute(
| ^
17 | "href",
18 | String(createUrl({ baseUrl, pathname: `/${locale}` })),
19 | );
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/metadata.test.ts:16:30
|
|
[chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url:
e2e/tests/app/metadata.test.ts#L16
3) [chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url ─────────────────────
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('link[rel="canonical"]')
Expected string: "http://localhost:3000/en"
Received: <element(s) not found>
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('link[rel="canonical"]')
14 |
15 | const canonicalUrl = indexPage.page.locator('link[rel="canonical"]');
> 16 | await expect(canonicalUrl).toHaveAttribute(
| ^
17 | "href",
18 | String(createUrl({ baseUrl, pathname: `/${locale}` })),
19 | );
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/metadata.test.ts:16:30
|
|
[chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url:
e2e/tests/app/metadata.test.ts#L16
3) [chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url ─────────────────────
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 5000ms waiting for expect(locator).toHaveAttribute(expected)
Locator: locator('link[rel="canonical"]')
Expected string: "http://localhost:3000/en"
Received: <element(s) not found>
Call log:
- expect.toHaveAttribute with timeout 5000ms
- waiting for locator('link[rel="canonical"]')
14 |
15 | const canonicalUrl = indexPage.page.locator('link[rel="canonical"]');
> 16 | await expect(canonicalUrl).toHaveAttribute(
| ^
17 | "href",
18 | String(createUrl({ baseUrl, pathname: `/${locale}` })),
19 | );
at /home/runner/work/oad-mamems/oad-mamems/e2e/tests/app/metadata.test.ts:16:30
|
|
Validate (20.x, ubuntu-latest):
components/entity-details.vue#L59
Variable 'relations' is already declared in the upper scope
|
|
Validate (20.x, ubuntu-latest):
components/search-form.vue#L48
Variable 'category' is already declared in the upper scope
|
|
Validate (20.x, ubuntu-latest):
components/ui/collapsible/Collapsible.vue#L16
Variable 'open' is already declared in the upper scope
|
|
Validate (20.x, ubuntu-latest):
e2e/tests/pages/imprint.test.ts#L43
Unexpected use of the `.skip()` annotation
|
|
Validate (20.x, ubuntu-latest):
e2e/tests/pages/index.test.ts#L29
Unexpected use of the `.skip()` annotation
|
|
Validate (20.x, ubuntu-latest)
No files were found with the provided path: playwright-report/. No artifacts will be uploaded.
|
|
🎭 Playwright Run Summary
4 failed
[chromium] › tests/app/app.test.ts:137:2 › app › should skip to main content with skip-link ────
[chromium] › tests/app/app.test.ts:148:2 › app › should set `lang` attribute on `html` element ─
[chromium] › tests/app/metadata.test.ts:10:1 › should set a canonical url ──────────────────────
[chromium] › tests/app/metadata.test.ts:40:1 › should set page metadata ────────────────────────
9 did not run
11 passed (1.1m)
|