impl fnd 001 002 003 api #500

wjeongchoi · 2024-07-27T11:05:18Z

요약 *

It closes #474

이렇게 복잡한 api를 짜는건 처음이라 이 방식이 맞는지 확신이 없습니다..
코드가 많이 길지만 꼼꼼히 봐주시면 감사하겠습니다

스크린샷

이후 Task *

없음

netlify · 2024-07-27T11:06:00Z

✅ Deploy Preview for jazzy-klepon-c756b5 ready!

Name	Link
🔨 Latest commit	`f41c8e2`
🔍 Latest deploy log	https://app.netlify.com/sites/jazzy-klepon-c756b5/deploys/66b0c6b6cf611a0008399e32
😎 Deploy Preview	https://deploy-preview-500--jazzy-klepon-c756b5.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 80 Accessibility: 100 Best Practices: 100 SEO: 92 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

wjeongchoi · 2024-08-02T17:24:05Z

packages/api/src/feature/funding/service/funding.service.ts

+    const tradeEvidenceFileIds =
+      await this.fundingRepository.selectTradeEvidenceFileIdsByFundingId(
+        param.id,
+      );
+
+    const tradeEvidenceFiles = await Promise.all(
+      tradeEvidenceFileIds.map(async id =>
+        this.filePublicService.getFileInfoById(id.toString()),
+      ),
+    );


질문: 이런식으로 id를 fundingRepository에서 받아오고 filePublicService에서 그걸 이용해서 파일을 가져오는데 맞는 방식인지 궁금합니다

맞습니다! 다만 dlfjaus 쿼리가 많아져서 성능 하락이 있을수 있는데, 최종 테스트시 크게 느려보이지 않는다면 미래의 최적화 todo가 될거 같아요 주석 정도 달아주시면 감사하겠습니다

wjeongchoi · 2024-08-02T17:25:08Z

packages/api/src/feature/funding/service/funding.service.ts

+    const transportationPassengerTIds =
+      await this.fundingRepository.selectPassengerStudentIdsByFundingId(
+        param.id,
+      );
+
+    const transportationPassengerIds = await Promise.all(
+      transportationPassengerTIds.map(async id =>
+        this.studentRepository.selectStudentIdByStudentTId(id),
+      ),
+    );
+
+    const transportationPassengers = await Promise.all(
+      transportationPassengerIds.map(async id => {
+        const student = await this.userRepository.findStudentById(id.id)[0];
+        return {
+          name: student.name,
+          studentNumber: student.studentNumber,
+        };
+      }),
+    );


transportationPassengers가 StudentT에서 student_id를 가져오길래 이렇게 했는데 맞는 방법인지 확인 필요

❗ UserPublicService를 통해 가져오면 됩니당

wjeongchoi · 2024-08-02T17:25:32Z

packages/api/src/feature/user/repository/student.repository.ts

+      .from(Student)
+      .where(and(eq(Student.id, studentId), isNull(StudentT.deletedAt)));
+
+    return result[0];


result[0]하면 되는거 맞나요

❗ 뭔가 이상한 거 같아요

메소드명이 selectStudentIdByStudentTId 인데 select 조건은 StudentId입니다.

질문에 대한 대답은 studentId(또는 studentTId)가 매치하는 row가 없다면 result가 길이 0의 배열일 수 있으므로, 이 selection을 호출하는 서비스또는 이 메소드에서 이러한 케이스를 예외로 처리하는것이 안전하다고 생각합니다.

wjeongchoi · 2024-08-02T17:26:17Z

packages/api/src/feature/funding/repository/funding.repository.ts

+      const [fundingInsertResult] = await tx.insert(FundingOrder).values({
+        clubId: contents.clubId,
+        purposeId: contents.purposeId,
+        // TODO: semesterId 받아오기
+        semesterId: 1,
+        fundingOrderStatusEnumId: Number(FundingOrderStatusEnum.Applied),
+        name: contents.name,
+        expenditureDate: contents.expenditureDate,
+        expenditureAmount: contents.expenditureAmount,
+        tradeDetailExplanation: contents.tradeDetailExplanation,
+        clubSuppliesName: contents.clubSuppliesName,
+        clubSuppliesEvidenceEnumId: contents.clubSuppliesEvidenceEnumId,
+        clubSuppliesClassEnumId: contents.clubSuppliesClassEnumId,
+        clubSuppliesPurpose: contents.clubSuppliesPurpose,
+        clubSuppliesSoftwareEvidence: contents.clubSuppliesSoftwareEvidence,
+        numberOfClubSupplies: contents.numberOfClubSupplies,
+        priceOfClubSupplies: contents.priceOfClubSupplies,
+        isFixture: contents.isFixture,
+        fixtureName: contents.fixtureName,
+        fixtureEvidenceEnumId: contents.fixtureEvidenceEnumId,
+        fixtureClassEnumId: contents.fixtureClassEnumId,
+        fixturePurpose: contents.fixturePurpose,


이렇게 하나씩 다 써줘야하는게 진짜 맞는지..?

Engineer-JJHaMa

일단 보이는거 위주로 했어유

Engineer-JJHaMa · 2024-08-04T21:49:01Z

packages/api/src/feature/file/service/file.public.service.ts

👍 로직자체는 깔끔합니다. Public Service인 만큼 jsDoc만 달면 좋을거 같아요. ClubPublicService에 예시가 몇개 있을 것 같습니다.

Engineer-JJHaMa · 2024-08-04T21:50:07Z

packages/api/src/feature/file/service/file.public.service.ts

❓ 추가로, getSignedUrl 함수는 예외 컨트롤을 안해도 되는지가 궁금한 부분인데, @pbc1017 께서 수정하실때 확인해주세요

Engineer-JJHaMa · 2024-08-04T21:56:18Z

packages/api/src/feature/user/repository/student.repository.ts

+      .from(Student)
+      .where(and(eq(Student.id, studentId), isNull(StudentT.deletedAt)));
+
+    return result[0];


❗ 뭔가 이상한 거 같아요

메소드명이 selectStudentIdByStudentTId 인데 select 조건은 StudentId입니다.

질문에 대한 대답은 studentId(또는 studentTId)가 매치하는 row가 없다면 result가 길이 0의 배열일 수 있으므로, 이 selection을 호출하는 서비스또는 이 메소드에서 이러한 케이스를 예외로 처리하는것이 안전하다고 생각합니다.

Engineer-JJHaMa · 2024-08-04T22:04:00Z

packages/api/src/feature/funding/controller/funding.controller.ts

❗ 인증 구현이 완료되었으니 mockId 대신 연결해야 할 것 같아요

Engineer-JJHaMa · 2024-08-05T00:54:08Z

packages/api/src/feature/funding/service/funding.service.ts

+    const user = await this.userRepository.findStudentById(studentId);
+    if (!user) {
+      throw new HttpException("Student not found", HttpStatus.NOT_FOUND);
+    }


❗ 학생이 해당 동아리 대표자인지 확인이 필요합니다. 다른 서비스도 AuthZ가 필요한지 검토해 주세요

❗ 추가로 제출 양식에 맞게 제출하였는지 확인하고 예외를 발생시키거나, 조건에 맞지 않는 제출을 일부 지우는 로직이 필요할 것 같아요

Engineer-JJHaMa · 2024-08-05T01:00:13Z

packages/api/src/feature/funding/service/funding.service.ts

+    const tradeEvidenceFileIds =
+      await this.fundingRepository.selectTradeEvidenceFileIdsByFundingId(
+        param.id,
+      );
+
+    const tradeEvidenceFiles = await Promise.all(
+      tradeEvidenceFileIds.map(async id =>
+        this.filePublicService.getFileInfoById(id.toString()),
+      ),
+    );


맞습니다! 다만 dlfjaus 쿼리가 많아져서 성능 하락이 있을수 있는데, 최종 테스트시 크게 느려보이지 않는다면 미래의 최적화 todo가 될거 같아요 주석 정도 달아주시면 감사하겠습니다

Engineer-JJHaMa · 2024-08-05T01:03:14Z

packages/api/src/feature/funding/service/funding.service.ts

+    const transportationPassengerTIds =
+      await this.fundingRepository.selectPassengerStudentIdsByFundingId(
+        param.id,
+      );
+
+    const transportationPassengerIds = await Promise.all(
+      transportationPassengerTIds.map(async id =>
+        this.studentRepository.selectStudentIdByStudentTId(id),
+      ),
+    );
+
+    const transportationPassengers = await Promise.all(
+      transportationPassengerIds.map(async id => {
+        const student = await this.userRepository.findStudentById(id.id)[0];
+        return {
+          name: student.name,
+          studentNumber: student.studentNumber,
+        };
+      }),
+    );


❗ UserPublicService를 통해 가져오면 됩니당

Engineer-JJHaMa

엄청 큰 API여서 귀찮았을텐데 잘 짜주셔서 감사합니다 👍 👍

Engineer-JJHaMa · 2024-08-05T09:45:43Z

packages/api/src/feature/user/service/user.public.service.ts

+  async getStudentByTId(studentT: { id: number }) {
+    const studentIds = await this.studentRepository.selectStudentIdByStudentTId(
+      studentT.id,
+    );
+
+    const students = await Promise.all(
+      studentIds.map(async student =>
+        this.studentRepository.selectStudentById(student.studentId),
+      ),
+    );
+
+    if (students.length > 1)
+      throw new HttpException("unreachable", HttpStatus.INTERNAL_SERVER_ERROR);
+
+    if (students.length === 0) {
+      return undefined;
+    }
+
+    return students[0][0];
+  }


💊 똑같이 PublicService이기에 JSDoc 달려있으면 좋을것같고, studentTId 로 select 후 배열 길이가 1인지 한번 조사하면 좋을듯 합니다(💊 이니 제안정도임!)

wjeongchoi added 3 commits July 26, 2024 10:11

feat: impl funding controller

69faba9

Merge branch 'dev' into 474-impl-fnd-001-002-003-api

c8beda2

feat: impl funding module

e38f70b

wjeongchoi added new feature 새로운 기능을 추가하는 경우입니다 back-end labels Jul 27, 2024

wjeongchoi self-assigned this Jul 27, 2024

wjeongchoi linked an issue Jul 27, 2024 that may be closed by this pull request

Impl FND 001 002 003 api #474

Closed

2 tasks

wjeongchoi added 15 commits July 29, 2024 18:16

fix: delete cargoList

5dcb137

feat: impl funding schema

a04aaaa

feat: impl postStudentFunding

d6c616b

feat: impl selectFundingByFundingId

b58cde8

feat: impl putStudentFunding

ddbf681

feat: select for selectFundingByFundingId

a134fce

feat: add file name and link to schema

8c1a8ff

feat: add file name and link to interface

3997d49

feat: move getFileUrl to public

2e2ca95

fix: fix file id

610036c

fix: fix file id for interface

c69e98b

feat: impl funding repository

745b7d2

feat: impl file public service

7d4bcea

feat: finish fnd 001 2 3

27bccdb

fix: fix import

cadad35

wjeongchoi marked this pull request as ready for review August 2, 2024 17:18

wjeongchoi requested review from Engineer-JJHaMa, pbc1017 and Jiuuung August 2, 2024 17:18

fix: fix mockFundingDetail

ed2bd3d

wjeongchoi commented Aug 2, 2024

View reviewed changes

Engineer-JJHaMa requested changes Aug 5, 2024

View reviewed changes

wjeongchoi added 6 commits August 5, 2024 15:43

fix: use userPublicService

3d9d086

Merge branch 'dev' into 474-impl-fnd-001-002-003-api

8ab90d6

feat: add student auth

cd1ea0f

feat: delegate check

e1e4d4b

feat: delete unused content

8bfe1ec

feat: filtering funding contents

43df2f5

wjeongchoi requested a review from Engineer-JJHaMa August 5, 2024 07:45

Engineer-JJHaMa approved these changes Aug 5, 2024

View reviewed changes

wjeongchoi added 2 commits August 5, 2024 21:30

feat: add error handling

70964d4

feat: add jsdoc

f41c8e2

wjeongchoi merged commit dae3864 into dev Aug 5, 2024
4 checks passed

wjeongchoi deleted the 474-impl-fnd-001-002-003-api branch August 5, 2024 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impl fnd 001 002 003 api #500

impl fnd 001 002 003 api #500

wjeongchoi commented Jul 27, 2024 •

edited

Loading

netlify bot commented Jul 27, 2024 •

edited

Loading

wjeongchoi Aug 2, 2024

Engineer-JJHaMa Aug 5, 2024

wjeongchoi Aug 2, 2024

Engineer-JJHaMa Aug 5, 2024

wjeongchoi Aug 2, 2024

Engineer-JJHaMa Aug 4, 2024

wjeongchoi Aug 2, 2024

Engineer-JJHaMa left a comment

Engineer-JJHaMa Aug 4, 2024

Engineer-JJHaMa Aug 4, 2024

Engineer-JJHaMa Aug 4, 2024

Engineer-JJHaMa Aug 4, 2024

Engineer-JJHaMa Aug 5, 2024

Engineer-JJHaMa Aug 5, 2024

Engineer-JJHaMa Aug 5, 2024

Engineer-JJHaMa Aug 5, 2024

Engineer-JJHaMa left a comment

Engineer-JJHaMa Aug 5, 2024

impl fnd 001 002 003 api #500

impl fnd 001 002 003 api #500

Conversation

wjeongchoi commented Jul 27, 2024 • edited Loading

요약 *

스크린샷

이후 Task *

netlify bot commented Jul 27, 2024 • edited Loading

✅ Deploy Preview for jazzy-klepon-c756b5 ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Engineer-JJHaMa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Engineer-JJHaMa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wjeongchoi commented Jul 27, 2024 •

edited

Loading

netlify bot commented Jul 27, 2024 •

edited

Loading