fix: isActivityReportUnverifiable logic

academic-relations · Jan 24, 2025 · f14e31e · f14e31e
1 parent 28e7d1a
commit f14e31e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/web/src/features/manage-club/funding/detail/frames/FundingDetailFrame.tsx b/packages/web/src/features/manage-club/funding/detail/frames/FundingDetailFrame.tsx
@@ -139,10 +139,10 @@ const FundingDetailFrame: React.FC<FundingDetailFrameProps> = ({
         <AsyncBoundary isLoading={isLoading} isError={isError}>
           <FundingInfoList data={funding} />
           <BasicEvidenceList data={funding} />
-          {funding.purposeActivity &&
-            isActivityReportUnverifiable(funding.purposeActivity.id) && (
-              <FixtureEvidenceList data={funding} />
-            )}
+          {(!funding.purposeActivity ||
+            isActivityReportUnverifiable(funding.purposeActivity.id)) && (
+            <FixtureEvidenceList data={funding} />
+          )}
           {funding.isFixture && (
             <FixtureEvidenceList isFixture data={funding} />
           )}

diff --git a/packages/web/src/features/manage-club/funding/types/funding.ts b/packages/web/src/features/manage-club/funding/types/funding.ts
@@ -98,4 +98,4 @@ export interface AddEvidence {
 export type FundingFormData = FundingInfo & BasicEvidence & AddEvidence;
 
 export const isActivityReportUnverifiable = (purposeId?: number) =>
-  purposeId === Infinity;
+  purposeId === Infinity || purposeId == null;