Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix Websocket Adapter #2700

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rodneyosodo
Copy link
Member

@rodneyosodo rodneyosodo commented Feb 11, 2025

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

To be merged after #2695

@rodneyosodo rodneyosodo requested a review from a team as a code owner February 11, 2025 12:05
@rodneyosodo rodneyosodo changed the title WS NOISSUE - Fix Websocket Adapter Feb 11, 2025
@rodneyosodo rodneyosodo marked this pull request as draft February 11, 2025 12:08
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 40.90909% with 156 lines in your changes missing coverage. Please review.

Project coverage is 34.63%. Comparing base (597ad23) to head (55c53cb).

Files with missing lines Patch % Lines
pkg/messaging/mqtt/pubsub.go 71.83% 27 Missing and 13 partials ⚠️
mqtt/forwarder.go 0.00% 31 Missing ⚠️
mqtt/tracing/forwarder.go 0.00% 31 Missing ⚠️
ws/handler.go 0.00% 31 Missing ⚠️
pkg/messaging/mqtt/publisher.go 23.07% 18 Missing and 2 partials ⚠️
ws/adapter.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2700      +/-   ##
==========================================
- Coverage   42.28%   34.63%   -7.65%     
==========================================
  Files         349      252      -97     
  Lines       47349    38480    -8869     
==========================================
- Hits        20021    13329    -6692     
+ Misses      25154    24086    -1068     
+ Partials     2174     1065    -1109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This reverts commit cff6e7f.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This reverts commit 87db3e6.

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Use rabbitMQ alpine rather than management-alpine since we are enabling
that feature using config files

Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant