NOISSUE - Use RabbitMQ as MQTT broker #2695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
rabbitmq
branch
3 times, most recently
from
49dfbb5 to
518b59e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
- Coverage 42.28% 34.60% -7.68%
==========================================
Files 349 252 -97
Lines 47349 38518 -8831
==========================================
- Hits 20021 13329 -6692
+ Misses 25154 24125 -1029
+ Partials 2174 1064 -1110 ☔ View full report in Codecov by Sentry. |
rodneyosodo
force-pushed
the
rabbitmq
branch
3 times, most recently
from
1fa3a37 to
e98d585
Compare
|
@rodneyosodo Please rebase. |
dborovcanin
requested changes
Feb 11, 2025
Comment on lines
+228
to
+231
| interceptor := interceptor{ | ||
| username: cfg.MQTTTargetUsername, | ||
| password: cfg.MQTTTargetPassword, | ||
| } |
There was a problem hiding this comment.
Why do we need this interceptor to set username and password?
There was a problem hiding this comment.
RabbitMQ runs in two modes, with and without authentication. For our case devices, i.e, clients always have authentication (thingID and thingKey). So we either add the RabbitMQ username and password when sending the request or remove the username and password when forwarding the request to RabbitMQ
rodneyosodo
force-pushed
the
rabbitmq
branch
2 times, most recently
from
a6b294f to
db4a8ae
Compare
This reverts commit cff6e7f. Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
This reverts commit 87db3e6. Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Use rabbitMQ alpine rather than management-alpine since we are enabling that feature using config files Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
rodneyosodo
force-pushed
the
rabbitmq
branch
from
db4a8ae to
d12c628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the following functionality: Add RabbitMQ as a MQTT broker.
What does this do?
The changes update the MQTT adapter and Docker configurations across the project. In the MQTT adapter, new configuration fields, a connection interceptor, and enhanced publisher/forwarder logic have been introduced, including authentication and QoS support. Docker-related files have been modified to integrate RabbitMQ as the MQTT broker, with updated environment variables, deployment documentation, and RabbitMQ-specific settings. Additional improvements include new tracing middleware for MQTT forwarding, updated dependency versions, and comprehensive tests for the MQTT pub/sub functionality using Docker.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes. I have tested MQTT pubsub, COAP pubsub and HTTP pub. WS will be fixed in another PR
Did you document any new/modified feature?
Notes