Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-888 - Update channels SDK tests #2269

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Jun 4, 2024

What type of PR is this?

This is a feature as it updates the channels SDK tests.

What does this do?

This pr updates teh current tests in the sdk to conform to existing changes as well as increasing the coverage of the channels sdk tests.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Yes, the tests are the changes.

Did you document any new/modified feature?

No,

Notes

@felixgateru felixgateru marked this pull request as ready for review June 7, 2024 12:47
@arvindh123 arvindh123 requested a review from rodneyosodo June 10, 2024 10:13
arvindh123
arvindh123 previously approved these changes Jun 10, 2024
pkg/sdk/go/channels.go Outdated Show resolved Hide resolved
pkg/sdk/go/channels_test.go Show resolved Hide resolved
rodneyosodo
rodneyosodo previously approved these changes Jun 12, 2024
arvindh123
arvindh123 previously approved these changes Jun 26, 2024
rodneyosodo
rodneyosodo previously approved these changes Jun 26, 2024
@felixgateru felixgateru dismissed stale reviews from arvindh123 and rodneyosodo via be8d4f9 June 28, 2024 12:49
@felixgateru felixgateru force-pushed the mg888-channels branch 3 times, most recently from 2d2250c to 2f49cf3 Compare July 3, 2024 13:04
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@dborovcanin dborovcanin merged commit b8a1fe1 into absmach:main Jul 5, 2024
5 checks passed
andychao217 pushed a commit to andychao217/magistrala that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants