NOISSUE - Fix OPC-UA adapter #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arvindh123 and @rodneyosodo please review this PR |
WashingtonKK
force-pushed
the
opcua-adapter
branch
from
3e18964 to
436834b
Compare
arvindh123
reviewed
Mar 14, 2024
rodneyosodo
requested changes
Mar 18, 2024
rodneyosodo
force-pushed
the
opcua-adapter
branch
from
4477778 to
a335e41
Compare
arvindh123
reviewed
Mar 19, 2024
arvindh123
reviewed
Mar 19, 2024
rodneyosodo
requested changes
Mar 19, 2024
rodneyosodo
requested changes
Mar 20, 2024
rodneyosodo
requested changes
Mar 20, 2024
rodneyosodo
requested changes
Mar 20, 2024
WashingtonKK
force-pushed
the
opcua-adapter
branch
from
6c1d5f9 to
c8e37d4
Compare
arvindh123
previously approved these changes
Mar 25, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
dborovcanin
force-pushed
the
opcua-adapter
branch
from
c8e37d4 to
430b25b
Compare
dborovcanin
requested changes
Mar 26, 2024
dborovcanin
changed the title
WashingtonKK
force-pushed
the
opcua-adapter
branch
from
3ba08dc to
430b25b
Compare
dborovcanin
requested changes
Mar 27, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
dborovcanin
approved these changes
Apr 1, 2024
JeffMboya
pushed a commit
to JeffMboya/supermq
that referenced
this pull request
Apr 3, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 4, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 5, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Apr 7, 2024
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix because it fixes the opc-ua adapter and makes it fully functional.
What does this do?
Rectifies the node-id parsing, modifies event handling to sync with things service events to allow the adapter to work as expected.
Which issue(s) does this PR fix/relate to?
Resolves #2037
Have you included tests for your changes?
No
Did you document any new/modified feature?
Yes, documentation is updated.
Notes