Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

NOISSUE - Remove Prefixed signin and signup state #273

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rodneyosodo
Copy link
Member

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Dependency Update

What does this do?

This PR remove the prefix signin and signup state since the state might change if the clients clicks signing state and they don't have an account, the OAuth provider will make them signup

Which issue(s) does this PR fix/relate to?

No issue

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

  • Yes. Tested manually
  • No, and this is why:

Did you document any new/modified functionality?

  • Yes
  • No, and this is why: will update in docs repo

Notes

Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@6f492e9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage        ?   89.49%           
=======================================
  Files           ?        5           
  Lines           ?     1865           
  Branches        ?        0           
=======================================
  Hits            ?     1669           
  Misses          ?      133           
  Partials        ?       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin dborovcanin merged commit ecc75d1 into absmach:main Jun 4, 2024
4 checks passed
andychao217 pushed a commit to andychao217/magistrala-ui that referenced this pull request Sep 12, 2024
@rodneyosodo rodneyosodo deleted the remove-state branch October 22, 2024 08:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants