This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
MG-42 - Remove creation of a channel with a parent channel #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=======================================
Coverage ? 81.00%
=======================================
Files ? 3
Lines ? 179
Branches ? 0
=======================================
Hits ? 145
Misses ? 18
Partials ? 16 ☔ View full report in Codecov by Sentry. |
Musilah
reviewed
Mar 19, 2024
felixgateru
suggested changes
Mar 19, 2024
ianmuchyri
force-pushed
the
42-removeparentid
branch
from
59fce4a to
f003689
Compare
felixgateru
approved these changes
Mar 19, 2024
Musilah
approved these changes
Mar 19, 2024
ianmuchyri
force-pushed
the
42-removeparentid
branch
from
f003689 to
1c87c9f
Compare
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
force-pushed
the
42-removeparentid
branch
from
1c87c9f to
fbed9a7
Compare
dborovcanin
approved these changes
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
Removes the ability for a user to create a channel with another channel as the parent. This is because this is not supported on the magistrala core.
Which issue(s) does this PR fix/relate to?
parentID#42Have you included tests for your changes?
Did you document any new/modified functionality?
Notes