This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
NOISSUE - Fix send messages page time format #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
suggested changes
Mar 14, 2024
ianmuchyri
force-pushed
the
fixsendmessages
branch
from
3e51f08 to
dcd4831
Compare
rodneyosodo
approved these changes
Mar 14, 2024
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
force-pushed
the
fixsendmessages
branch
from
dcd4831 to
a8d3377
Compare
dborovcanin
reviewed
Mar 14, 2024
ui/service.go
Outdated
| statusOptions = []string{"all", "enabled", "disabled"} | ||
| uuidPattern = "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[1-5][0-9a-fA-F]{3}-[89abAB][0-9a-fA-F]{3}-[0-9a-fA-F]{12}$" | ||
| intervalPattern = "^([0-9][0-9]*[smhd])$" | ||
| MilliToNanoConverter = math.Pow10(6) |
There was a problem hiding this comment.
Use to MilliToNanoRatio = 1e6.
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage ? 76.74%
=======================================
Files ? 3
Lines ? 215
Branches ? 0
=======================================
Hits ? 165
Misses ? 34
Partials ? 16 ☔ View full report in Codecov by Sentry. |
dborovcanin
approved these changes
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this do?
fix read messages page time format to be precision independent.
Which issue(s) does this PR fix/relate to?
NOISSUE
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes