Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Commit

Permalink
fix makefile
Browse files Browse the repository at this point in the history
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
  • Loading branch information
ianmuchyri committed Nov 15, 2023
1 parent b40d5fb commit 227bb66
Showing 1 changed file with 13 additions and 17 deletions.
30 changes: 13 additions & 17 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Copyright (c) Abstract Machines
# SPDX-License-Identifier: Apache-2.0

MG_DOCKER_IMAGE_NAME_PREFIX ?= magistrala
SVC = ui
MG_DOCKER_IMAGE_NAME_PREFIX ?= ghcr.io/absmach
SVC = magistrala-ui
BUILD_DIR = build
CGO_ENABLED ?= 0
GOOS ?= linux
@@ -17,37 +17,33 @@ define compile_service
-X 'github.com/absmach/magistrala-ui.BuildTime=$(TIME)' \
-X 'github.com/absmach/magistrala-ui.Version=$(VERSION)' \
-X 'github.com/absmach/magistrala-ui.Commit=$(COMMIT)'" \
-o ${BUILD_DIR}/magistrala-$(1) cmd/$(1)/main.go
-o ${BUILD_DIR}/magistrala-ui cmd/ui/main.go
endef

define make_docker
$(eval svc=$(subst docker_,,$(1)))

docker build \
--no-cache \
--build-arg SVC=$(svc) \
--build-arg SVC=$(SVC) \
--build-arg GOARCH=$(GOARCH) \
--build-arg GOARM=$(GOARM) \
--build-arg VERSION=$(VERSION) \
--build-arg COMMIT=$(COMMIT) \
--build-arg TIME=$(TIME) \
--tag=$(MF_DOCKER_IMAGE_NAME_PREFIX)/$(svc) \
--tag=$(MF_DOCKER_IMAGE_NAME_PREFIX)/$(SVC) \
-f docker/Dockerfile .
endef

define make_docker_dev
$(eval svc=$(subst docker_dev_,,$(1)))

docker build \
--no-cache \
--build-arg SVC=$(svc) \
--tag=$(MG_DOCKER_IMAGE_NAME_PREFIX)/$(svc) \
--build-arg SVC=$(SVC) \
--tag=$(MG_DOCKER_IMAGE_NAME_PREFIX)/$(SVC) \
-f docker/Dockerfile.dev .
endef

all: ui
all: magistrala-ui

.PHONY: ui docker docker_dev
.PHONY: magistrala-ui docker docker_dev run_docker run

clean:
rm -rf ${BUILD_DIR}
@@ -66,14 +62,14 @@ lint:
golangci-lint run --no-config --disable-all --enable gosimple --enable errcheck --enable govet --enable unused --enable goconst --enable godot --timeout 3m
prettier --check --write ui

ui:
$(call compile_service,$(@))
magistrala-ui:
$(call compile_service)

docker:
$(call make_docker,ui)
$(call make_docker)

docker_dev:
$(call make_docker_dev,ui)
$(call make_docker_dev)

run_docker:
docker-compose -f docker/docker-compose.yml --env-file docker/.env up

0 comments on commit 227bb66

Please sign in to comment.