-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added liferay advisories - Fix #1410 #1774
base: main
Are you sure you want to change the base?
Conversation
…ES.rst and __init__.py Signed-off-by: Shrish Mishra <shrish409@gmail.com> Signed-off-by: Shrish0098 <shrish409@gmail.com>
…h409@gmail.com> Signed-off-by: Shrish0098 <shrish409@gmail.com>
…@gmail.com> Signed-off-by: Shrish0098 <shrish409@gmail.com>
@pombredanne I have added the liferay advisories, please review it and let me know if any further changes are required. |
Hi @Dedsec0098 , I Would like to suggest you some changes which can make you liferay importer even more reliable as well as functional. Please feel free to correct me if I am wrong somewhere :) Some contributing advices
|
Hey @Rishi-source Thanks a lot for letting me know!! |
Do not worry about your unmerged PR while making a new PRs if both the pull req. have unrelated changes (changes which are not conflicting) then github will provide a update branch option whenever new changes are merged. |
@Dedsec0098 Thanks, if you could keep each PR separate, that would be much better. This is hard to merge otherwise. |
Sure @pombredanne, I will make the necessary changes |
Signed-off-by: Shrish0098 <shrish409@gmail.com>
66b5626
to
64b3efd
Compare
Hey @pombredanne I have separated this PR and also updated the PR message |
Fix #1410
Added liferay advisories by adding liferay.py in the importers
Updated init.py to register my importer
Signed-off-by: Shrish Mishra shrish409@gmail.com