-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHORE: Add release information for v.2.7.0 #1943
Conversation
- Update CHANGELOG - Update Ably package version
WalkthroughThis pull request introduces version 2.7.0 with several modifications to the Ably realtime client library. The changes primarily involve updates to enum definitions in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
## [2.7.0](https://github.com/ably/ably-js/tree/2.7.0) (2025-01-13) | ||
|
||
- Removed an incorrect channel mode `ATTACH_RESUME` from the `ChannelModes` enum. | ||
- Deprecates the `UNSET` type from `MESSAGE_ACTIONS` enum, all messages will always have their `action` set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecates
, or removes
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
5-11
: LGTM! Consider adding migration notes for deprecated features.The changelog entries are clear and well-structured. However, since multiple features are being deprecated, it would be helpful to add migration notes or links to documentation explaining the recommended alternatives for:
- Using message actions now that
UNSET
is deprecated- Handling annotations after
ANNOTATION_CREATE
andANNOTATION_DELETE
are deprecated
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.json
is excluded by!**/package-lock.json
📒 Files selected for processing (3)
CHANGELOG.md
(1 hunks)package.json
(1 hunks)src/platform/react-hooks/src/AblyReactHooks.ts
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- package.json
- src/platform/react-hooks/src/AblyReactHooks.ts
⏰ Context from checks skipped due to timeout of 90000ms (13)
- GitHub Check: test-browser (webkit)
- GitHub Check: test-node (20.x)
- GitHub Check: test-browser (firefox)
- GitHub Check: test-node (18.x)
- GitHub Check: test-browser (chromium)
- GitHub Check: test-node (16.x)
- GitHub Check: test-npm-package
- GitHub Check: test-node (20.x)
- GitHub Check: test-node (18.x)
- GitHub Check: test-browser (webkit)
- GitHub Check: test-browser (firefox)
- GitHub Check: test-node (16.x)
- GitHub Check: test-browser (chromium)
Summary by CodeRabbit
ATTACH_RESUME
channel modeUNSET
,ANNOTATION_CREATE
, andANNOTATION_DELETE
message actionsMESSAGE_SUMMARY
message action type