Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importing the library via script tag adds each named export of ably to the global namespace on v2 branch #1607

Closed
VeskeR opened this issue Feb 1, 2024 · 2 comments · Fixed by #1558
Closed

Fix importing the library via script tag adds each named export of ably to the global namespace on v2 branch #1607

VeskeR opened this issue Feb 1, 2024 · 2 comments · Fixed by #1558
Assignees
@VeskeR
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@VeskeR
Copy link
Contributor

VeskeR commented Feb 1, 2024

When using UMD wrapper without commonjs/amd (importing library via the script tag, for example, via CDN), the esbuild-plugin-umd-wrapper plugin would add each named export of ably to the global namespace rather than adding it in an object called Ably (as it did in v1).
@VeskeR VeskeR added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 1, 2024
@VeskeR VeskeR linked a pull request Feb 1, 2024 that will close this issue
build: use Ably as UMD lib name #1558
Merged
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Feb 1, 2024

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-4073

VeskeR added a commit that referenced this issue Feb 1, 2024
@VeskeR
Changes UMD wrapper to use anonymous bundles for AMD resolution
c50038b 
Resolves #1607
VeskeR added a commit that referenced this issue Feb 1, 2024
@VeskeR
Changes UMD wrapper to use anonymous bundles for AMD resolution
359f1b1 
Resolves #1607
VeskeR added a commit that referenced this issue Feb 2, 2024
@VeskeR
Changes UMD wrapper to use anonymous bundles for AMD resolution
41686c0 
Resolves #1607
@VeskeR
Copy link
Contributor Author

VeskeR commented Feb 2, 2024

Fixed in #1558

@VeskeR VeskeR closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VeskeR VeskeR

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: use Ably as UMD lib name ably/ably-js
1 participant
@VeskeR