Skip to content

Commit

Permalink
Fix test failures
Browse files Browse the repository at this point in the history
channelSerial test should have always expected `channelSerial` value,
but was wrongly set to `channelSerial2` in #1961.

live_objects connectionDetails.maxMessageSize test wrongly used obsolete
`expectRejectedWith` function due to PR merge order.
  • Loading branch information
VeskeR committed Feb 12, 2025
1 parent 2f5d208 commit d50ea2d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/realtime/channel.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ define(['ably', 'shared_helper', 'async', 'chai'], function (Ably, Helper, async
transport.send = function (msg) {
if (msg.action === 10) {
try {
expect(msg.channelSerial).to.equal('channelSerial2');
expect(msg.channelSerial).to.equal('channelSerial');
resolve();
} catch (error) {
reject(error);
Expand Down
2 changes: 1 addition & 1 deletion test/realtime/live_objects.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4246,7 +4246,7 @@ define(['ably', 'shared_helper', 'chai', 'live_objects', 'live_objects_helper'],
const root = await liveObjects.getRoot();

const data = new Array(100).fill('a').join('');
const error = await expectRejectedWith(
const error = await expectToThrowAsync(
async () => root.set('key', data),
'Maximum size of state messages that can be published at once exceeded',
);
Expand Down

0 comments on commit d50ea2d

Please sign in to comment.