Skip to content

Commit

Permalink
wip add proxy agents to realtime presence history
Browse files Browse the repository at this point in the history
  • Loading branch information
lawrence-forooghian committed Feb 13, 2025
1 parent 461ba88 commit 880a3c5
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
13 changes: 7 additions & 6 deletions Source/ARTRestPresence.m
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@ - (BOOL)get:(ARTPresenceQuery *)query callback:(ARTPaginatedPresenceCallback)cal
}

- (BOOL)history:(nullable ARTDataQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError *_Nullable *_Nullable)errorPtr {
return [_internal history:query callback:callback error:errorPtr];
return [_internal history:query wrapperSDKAgents:nil callback:callback error:errorPtr];
}

- (void)history:(ARTPaginatedPresenceCallback)callback {
[_internal history:callback];
[_internal historyWithWrapperSDKAgents:nil completion:callback];
}

@end
Expand Down Expand Up @@ -161,11 +161,12 @@ - (BOOL)get:(ARTPresenceQuery *)query callback:(ARTPaginatedPresenceCallback)cal
return YES;
}

- (void)history:(ARTPaginatedPresenceCallback)callback {
[self history:[[ARTDataQuery alloc] init] callback:callback error:nil];
- (void)historyWithWrapperSDKAgents:(nullable NSStringDictionary *)wrapperSDKAgents
completion:(ARTPaginatedPresenceCallback)callback {
[self history:[[ARTDataQuery alloc] init] wrapperSDKAgents:wrapperSDKAgents callback:callback error:nil];
}

- (BOOL)history:(ARTDataQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
- (BOOL)history:(ARTDataQuery *)query wrapperSDKAgents:(nullable NSStringDictionary *)wrapperSDKAgents callback:(ARTPaginatedPresenceCallback)callback error:(NSError **)errorPtr {
if (callback) {
void (^userCallback)(ARTPaginatedResult<ARTPresenceMessage *> *result, ARTErrorInfo *error) = callback;
callback = ^(ARTPaginatedResult<ARTPresenceMessage *> *result, ARTErrorInfo *error) {
Expand Down Expand Up @@ -217,7 +218,7 @@ - (BOOL)history:(ARTDataQuery *)query callback:(ARTPaginatedPresenceCallback)cal
};

dispatch_async(_queue, ^{
[ARTPaginatedResult executePaginated:self->_channel.rest withRequest:request andResponseProcessor:responseProcessor wrapperSDKAgents:nil logger:self->_logger callback:callback];
[ARTPaginatedResult executePaginated:self->_channel.rest withRequest:request andResponseProcessor:responseProcessor wrapperSDKAgents:wrapperSDKAgents logger:self->_logger callback:callback];
});
return YES;
}
Expand Down
5 changes: 3 additions & 2 deletions Source/PrivateHeaders/Ably/ARTRestPresence+Private.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ NS_ASSUME_NONNULL_BEGIN

- (BOOL)get:(ARTPresenceQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError *_Nullable *_Nullable)errorPtr;

- (BOOL)history:(nullable ARTDataQuery *)query callback:(ARTPaginatedPresenceCallback)callback error:(NSError *_Nullable *_Nullable)errorPtr;
- (BOOL)history:(nullable ARTDataQuery *)query wrapperSDKAgents:(nullable NSStringDictionary *)wrapperSDKAgents callback:(ARTPaginatedPresenceCallback)callback error:(NSError *_Nullable *_Nullable)errorPtr;

- (void)history:(ARTPaginatedPresenceCallback)callback;
- (void)historyWithWrapperSDKAgents:(nullable NSStringDictionary *)wrapperSDKAgents
completion:(ARTPaginatedPresenceCallback)callback;

@end

Expand Down

0 comments on commit 880a3c5

Please sign in to comment.